Skip to content

Commit

Permalink
Fix default of helm.releases.<>.apiVersions (#42)
Browse files Browse the repository at this point in the history
The previous value included only the `<group>.<version>`, e.g. `monitoring.coreos.com/v1`.

But Helm charts actually also check for e.g. `monitoring.coreos.com/v1/ServiceMonitor`. For this reason we need both.
  • Loading branch information
felixscheinost authored Nov 10, 2023
1 parent ea469ff commit fceda84
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion modules/helm.nix
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,12 @@ in
If you use `kubernetes.customTypes` to make kubenix aware of CRDs, it will include those as well by default.
'';
type = types.listOf types.str;
default = builtins.map (customType: "${customType.group}/${customType.version}")
default = builtins.concatMap
(customType:
[
"${customType.group}/${customType.version}"
"${customType.group}/${customType.version}/${customType.kind}"
])
(builtins.attrValues globalConfig.kubernetes.customTypes);
};

Expand Down

0 comments on commit fceda84

Please sign in to comment.