-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vcf file processing #124
Open
jelman
wants to merge
5
commits into
hakyimlab:master
Choose a base branch
from
jelman:vcf_file_update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
21ac8a8
Load dosage such that 2=HOM_ALT instead of 2=UNKNOWN
jelman 969ec55
alts loaded as list, check length of first element
jelman d2ad59f
Check for multiples in REFs and ALTs
jelman a88810b
logging.log() requires integer level
jelman bb678f3
Use numpy.nanmean to allow for nans
jelman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,7 @@ | |
|
||
def vcf_file_geno_lines(path, mode="genotyped", variant_mapping=None, whitelist=None, skip_palindromic=False, liftover_conversion=None): | ||
logging.log(9, "Processing vcf %s", path) | ||
vcf_reader = VCF(path) | ||
vcf_reader = VCF(path, gts012=True) | ||
|
||
is_dict_mapping = variant_mapping is not None and type(variant_mapping) == dict | ||
|
||
|
@@ -40,12 +40,12 @@ def vcf_file_geno_lines(path, mode="genotyped", variant_mapping=None, whitelist= | |
for sample in variant.genotypes: | ||
d_ = (sample[0] == a+1) + (sample[1] == a+1) | ||
d.append(d_) | ||
f = numpy.mean(numpy.array(d,dtype=numpy.int32))/2 | ||
f = numpy.nanmean(numpy.array(d,dtype=numpy.int32))/2 | ||
yield (variant_id, chr, pos, ref, alt, f) + tuple(d) | ||
|
||
elif mode == "imputed": | ||
if len(alts) > 1: | ||
logging.log("VCF imputed mode doesn't support multiple ALTs, skipping %s", variant_id) | ||
if (len(ref)) | (len(alts[0])) > 1: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The genotype contains indels too? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, and they could be coded as either REF or ALT. |
||
logging.log(8, "VCF imputed mode doesn't support multiple REFs or ALTs, skipping %s", variant_id) | ||
continue | ||
|
||
alt = alts[0] | ||
|
@@ -60,7 +60,7 @@ def vcf_file_geno_lines(path, mode="genotyped", variant_mapping=None, whitelist= | |
|
||
try: | ||
d = numpy.apply_along_axis(lambda x: x[0], 1, variant.format("DS")) | ||
f = numpy.mean(numpy.array(d)) / 2 | ||
f = numpy.nanmean(numpy.array(d)) / 2 | ||
yield (variant_id, chr, pos, ref, alt, f) + tuple(d) | ||
except KeyError: | ||
yield RuntimeError("Missing DS field when vcf mode is imputed") | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does gts012 represent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From cyvcf2.VCF documentation:
gts012 (bool) – if True, then gt_types will be 0=HOM_REF, 1=HET, 2=HOM_ALT, 3=UNKNOWN. If False, 3, 2 are flipped.