Skip to content

Commit

Permalink
internal/graphicsdriver/opengl/gl: fixes DeleteVertexArrays removing …
Browse files Browse the repository at this point in the history
…entry from textures instead of vertexArrays value store in webgl driver (#3125)

This is just what appears to be a typo in the WebGL driver that is deleting the mapping between a uint32 ID and a
JavaScript value for vertexArrays from the value store for the textures instead. This seems like it would potentially
cause a crash if the numbers aligned.
  • Loading branch information
LoparPanda authored Oct 8, 2024
1 parent 5bcfdee commit 5245537
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/graphicsdriver/opengl/gl/default_js.go
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ func (c *defaultContext) DeleteTexture(texture uint32) {

func (c *defaultContext) DeleteVertexArray(array uint32) {
c.fnDeleteVertexArray.Invoke(c.vertexArrays.get(array))
c.textures.delete(array)
c.vertexArrays.delete(array)
}

func (c *defaultContext) Disable(cap uint32) {
Expand Down

0 comments on commit 5245537

Please sign in to comment.