Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't double-prepend Error: to messages #245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Habbie
Copy link
Contributor

@Habbie Habbie commented Mar 10, 2023

before:

$ hp -b pkgdiff
Checking if any dependency-infos need to be updated ...
Looking for stale dependency-infos ...
Warning: skipping pkgdiff-1.7.2, as the recipe is broken
Error: Error: SUMMARY must start with a capital letter (/boot/home/haikuports/dev-util/pkgdiff/pkgdiff-1.7.2.recipe).
Error: No version of pkgdiff can be built

after:

$ hp -b pkgdiff
Checking if any dependency-infos need to be updated ...
Looking for stale dependency-infos ...
Warning: skipping pkgdiff-1.7.2, as the recipe is broken
Error: SUMMARY must start with a capital letter (/boot/home/haikuports/dev-util/pkgdiff/pkgdiff-1.7.2.recipe).
Error: No version of pkgdiff can be built

before:

$ hp -b pkgdiff
Checking if any dependency-infos need to be updated ...
Looking for stale dependency-infos ...
Warning: skipping pkgdiff-1.7.2, as the recipe is broken
Error: Error: SUMMARY must start with a capital letter (/boot/home/haikuports/dev-util/pkgdiff/pkgdiff-1.7.2.recipe).
Error: No version of pkgdiff can be built

after:

$ hp -b pkgdiff
Checking if any dependency-infos need to be updated ...
Looking for stale dependency-infos ...
Warning: skipping pkgdiff-1.7.2, as the recipe is broken
Error: SUMMARY must start with a capital letter (/boot/home/haikuports/dev-util/pkgdiff/pkgdiff-1.7.2.recipe).
Error: No version of pkgdiff can be built
@waddlesplash
Copy link
Member

Instead of calling .replace, which seems dangerous, shouldn't the origin of this double-error be fixed at the source?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants