Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic python recipes #232

Closed
wants to merge 9 commits into from
Closed

Conversation

Begasus
Copy link
Contributor

@Begasus Begasus commented Sep 14, 2022

I've been using this generic recipe for a while now, could be handy for others too?

@waddlesplash
Copy link
Member

IMHO, we should do something about the "duplication" of all this logic in every Python recipe.

Perhaps we should have a "templates" directory in the HaikuPorts repository with scriptlets/functions for specific recipe types, which could then be invoked and take care of the general logic here?

CC @korli, @OscarL

@OscarL
Copy link
Contributor

OscarL commented Apr 3, 2023

After reading haikuports/haikuports#2541... maybe something like korli suggested in his comment there?

Edit: we might need a couple of variants of that, as older packages tend to use "python setup.py build install" (via setuptools), and most newer ones do not have a setup.py anymore, using "pyproject.toml" (PEP-517) instead (thus requiring using "build" and "installer" on them).

Still, sounds like something worth doing. Perhaps after we finish cleaning up the 2.7/3.7 versions?

@Begasus Begasus force-pushed the generic branch 2 times, most recently from 643966d to a95f381 Compare May 18, 2023 14:24
@Begasus Begasus changed the title Add a generic python recipe Add a generic python recipes May 18, 2023
@Begasus Begasus changed the title Add a generic python recipes Add generic python recipes May 18, 2023
@Begasus
Copy link
Contributor Author

Begasus commented May 18, 2023

Made some changes to the default python recipe and added one for those using whl archives and one for using build/installer in the source.
For me they are a nice thing to have around to create a recipe for python packages quickly.

Copy link
Contributor

@OscarL OscarL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nit-picks regarding spacing, and some suggestions removing unneeded variables and dependencies.

The --skip-dependency-check is there because the dependencies it list are, AFAIK, runtime dependencies. If some of those are also build-dependencies, I prefer to to let the build fail and add them manually as needed.

generic/generic_python_build-1.2.3.recipe Outdated Show resolved Hide resolved
generic/generic_python_build-1.2.3.recipe Show resolved Hide resolved
generic/generic_python-1.2.3.recipe Outdated Show resolved Hide resolved
generic/generic_python-1.2.3.recipe Outdated Show resolved Hide resolved
generic/generic_python_wheel-1.2.3.recipe Outdated Show resolved Hide resolved
generic/generic_python_wheel-1.2.3.recipe Outdated Show resolved Hide resolved
generic/generic_python_wheel-1.2.3.recipe Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants