-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic python recipes #232
Conversation
IMHO, we should do something about the "duplication" of all this logic in every Python recipe. Perhaps we should have a "templates" directory in the HaikuPorts repository with scriptlets/functions for specific recipe types, which could then be invoked and take care of the general logic here? |
After reading haikuports/haikuports#2541... maybe something like korli suggested in his comment there? Edit: we might need a couple of variants of that, as older packages tend to use "python setup.py build install" (via setuptools), and most newer ones do not have a setup.py anymore, using "pyproject.toml" (PEP-517) instead (thus requiring using "build" and "installer" on them). Still, sounds like something worth doing. Perhaps after we finish cleaning up the 2.7/3.7 versions? |
643966d
to
a95f381
Compare
Made some changes to the default python recipe and added one for those using whl archives and one for using build/installer in the source. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor nit-picks regarding spacing, and some suggestions removing unneeded variables and dependencies.
The --skip-dependency-check
is there because the dependencies it list are, AFAIK, runtime dependencies. If some of those are also build-dependencies, I prefer to to let the build fail and add them manually as needed.
Co-authored-by: OscarL <[email protected]>
Co-authored-by: OscarL <[email protected]>
Co-authored-by: OscarL <[email protected]>
Co-authored-by: OscarL <[email protected]>
Co-authored-by: OscarL <[email protected]>
Co-authored-by: OscarL <[email protected]>
Co-authored-by: OscarL <[email protected]>
I've been using this generic recipe for a while now, could be handy for others too?