Skip to content

fix: keep Amazon login inside the plugin window #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joswr1ght wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: keep Amazon login inside the plugin window #338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/components/amazonLoginModal/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ export default class AmazonLoginModal {
show: false,
});

// Obsidian cancels http(s) navigations in every window it creates and reopens them in the
// system browser, ejecting the Amazon login flow. Drop that listener on the window we own.
this.modal.webContents.removeAllListeners('will-navigate');

// We can only change title after page is loaded since HTML page has its own title
this.modal.once('ready-to-show', () => {
this.modal.setTitle('Connect your Amazon account to Obsidian');
Expand Down
Loading