Skip to content

feat: ✨ added cors headers for share images #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jeffyang400
Copy link
Contributor

@jeffyang400 jeffyang400 commented Jul 9, 2025

Added the ability to store binary data/blob temporarily with a URL link.

@jeffyang400 jeffyang400 marked this pull request as ready for review July 9, 2025 20:17
@jeffyang400 jeffyang400 marked this pull request as draft July 9, 2025 20:17
@@ -15,7 +15,7 @@ class AbstractBlobStorage(models.Model):
size_bytes = models.PositiveIntegerField(default=0)
contents = CompressedBinaryField(
max_length=htk_setting('HTK_BLOB_CONTENT_MAX_LENGTH'),
editable=True
editable=True,
Copy link
Contributor Author

@jeffyang400 jeffyang400 Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comma here so that when I click 'Save', it doesn't become a one-liner with a max_length.

@jeffyang400 jeffyang400 marked this pull request as ready for review July 10, 2025 16:21
Copy link
Member

@jontsai jontsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jontsai jontsai merged commit 40c537b into hacktoolkit:master Jul 10, 2025
@jontsai jontsai deleted the feature/cors-headers-for-share-links branch July 10, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants