Skip to content

Conversation

@JamieXiao
Copy link
Contributor

Tickets:

• HCK-

List of changes:

• (I don't remember if the review statuses were previously merged or not)
• Added functionality to reviewer comments
• Added a new column in the 'Search Hackers' table called "Review Status" which shows the number of people that have reviewed a certain hacker's application
• Added a filter for 'Review Status' (0,1,2)

Type of change:

Please delete options that aren't relevant.
• New feature (non-breaking change which adds functionality)

How did you do this?

How to test:

Click on a hacker's "See more" and enter a reviewer status and name/comments. Wait a second or two, then click on the reload button. The changes should now be saved, and the hackers' "See more" should be updated as well as the "Review Status" column in the table (Note: the "Review Status" column only checks if the actual Reviewer Status is changed (AKA not none) or not; the name and comments do not matter).
Filter the table for hackers with 0/1/2 "Review Status".

Questions:

PR Checklist:

• Merged develop branch (before testing)
• Linted my code locally
• Listed change(s) in the Changelog
• Tested all links in project relevant browsers
• Tested all links on different screen sizes
• Referenced all useful info (issues, tasks, etc)

Screenshots:

[image](https://private-user-images.githubusercontent.com/141690843/495446706-be77ae44-735d-4e4d-b3f4-34b25ce98e35.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjA4NDAwNzIsIm5iZiI6MTc2MDgzOTc3MiwicGF0aCI6Ii8xNDE2OTA4NDMvNDk1NDQ2NzA2LWJlNzdhZTQ0LTczNWQtNGU0ZC1iM2Y0LTM0YjI1Y2U5OGUzNS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUxMDE5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MTAxOVQwMjA5MzJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hY2ZlZDUxMjZjYmM2ZjA1MWI1NGRlNDUzZTAwMzQxOTRmNGQ4YWZiM2FjMDVkYmE2MDc3ZWUzNDBlNTNkYzJkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.AZn7Wowx2ydjMwRsOesuPefCQ7eWMuMAtJnQECb0HIE) [image](https://private-user-images.githubusercontent.com/141690843/495446967-9be0da9c-f02f-449a-9541-e4400a70765a.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjA4NDAwNzIsIm5iZiI6MTc2MDgzOTc3MiwicGF0aCI6Ii8xNDE2OTA4NDMvNDk1NDQ2OTY3LTliZTBkYTljLWYwMmYtNDQ5YS05NTQxLWU0NDAwYTcwNzY1YS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUxMDE5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MTAxOVQwMjA5MzJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01NWE3MTVjYWZkZWFkMTYxMmYxZDI4MGE5OTdkMTA3NGQ3ODVhY2Q4MTkyYTczYmY5Nzg2NjRmZDEwNzE3YzQ4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.ryCxBUFq7cwCTrN5PpYR7A9XLHFmU_J7FRA7g0IZiC8)

@vercel
Copy link

vercel bot commented Oct 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
dashboard Ready Ready Preview Comment Oct 27, 2025 10:19pm

@tektaxi
Copy link
Contributor

tektaxi commented Oct 21, 2025

Works great!!

Not blocking:
The only thing I notice when using it is that the sorting by clicking on the column header doesn't work properly. When you do it on another column, it essentially works like "sort sheet a-z" in Google Sheets and rearranges the rows so that they are grouped by that column value. When you click again, it does z-a. Review score and review status seem to behave randomly when you try the same thing.

See below where the sheet is sorted by grad year, and it arranges them a-z.
Screenshot 2025-10-21 at 17 38 36

Copy link
Contributor

@tektaxi tektaxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :) Will wait on other reviews + backend changes before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants