Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions public/team.json
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,18 @@
"website": "",
"avatar": "https://avatars.githubusercontent.com/u/64415791"
},
{
"name": "Joaquin Schere",
"department": "Events",
"role": "Partnerships and Communications",
"acknowledged": false,
"bio": "Despite studying computer science all of high school, Joaquin had never had the courage to build a project himself until his first Hack Club hackathon. That first all-nighter changed his life, and now he's proud to work in Partnerships and Communications for the Events team, securing meaningful benefits and experiences for Hack Clubbers. When he's not writing emails to intimidating tech innovators, you can find him playing guitar or building websites.",
"bioHackFoundation": "",
"slackId": "U083W5CCFDG",
"email": "joaquin",
"website": "jschere.com",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: A team member's website field lacks an https:// protocol, causing the browser to treat the link as a relative path and making it non-functional.
Severity: HIGH | Confidence: High

🔍 Detailed Analysis

The website field for Joaquin (jschere.com) in public/team.json is missing the https:// protocol. When this value is used as the href attribute in an anchor tag within bio.js (lines 33-34 and 81-84), browsers interpret it as a relative path. This results in a malformed internal URL (e.g., https://hackclub.com/jschere.com) instead of navigating to the intended external website, rendering the link non-functional.

💡 Suggested Fix

Add the https:// protocol to the website field for jschere.com in public/team.json. Alternatively, implement URL normalization logic in bio.js to prepend https:// if a protocol is missing.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: public/team.json#L225

Potential issue: The `website` field for Joaquin (`jschere.com`) in `public/team.json`
is missing the `https://` protocol. When this value is used as the `href` attribute in
an anchor tag within `bio.js` (lines 33-34 and 81-84), browsers interpret it as a
relative path. This results in a malformed internal URL (e.g.,
`https://hackclub.com/jschere.com`) instead of navigating to the intended external
website, rendering the link non-functional.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 5729556

"avatar": "https://hc-cdn.hel1.your-objectstorage.com/s/v3/8d63d3533b6039468208f0ba4d5e422fd8af1a07_image.png"
},
{
"name": "Lux Loff",
"department": "HQ",
Expand Down