Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sudoku Game Drawer - Yash Vardhan Niranjan #888

Closed
wants to merge 9 commits into from

Conversation

Yash00241
Copy link

@Yash00241 Yash00241 commented Aug 31, 2024

Write a short description about your art piece, such as what your artwork represents and your experience drawing it!

Next, make sure you go through each item in the following checklist. Delete this line after!

  • I have read the steps to getting a blot
  • I am submitting art that...
    • is algorithmically generated (will meaningfully change each time the program is run)
    • is your own work that is not copied from somewhere else
    • is drawable through the editor(does not use outside tools)
    • doesn't call Math.random() (See the documentation on randomness)
    • is drawable on Blot itself (doesn't have lines overlap more than 5 times)
      • Doesn't overlap lines more than 5 times
      • Fits in the working area of 125x125mm
      • Doesn't rely on colour to look good

If you used based your art on something else, used a tutorial, or remixed it from something else, please link it here:

Lastly, link a picture of your art piece here:

Copy link

vercel bot commented Aug 31, 2024

@Yash00241 is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Aug 31, 2024

art/Yash Vardhan's Sudoku Game Drawer/index.js looks like art! preview it in the editor

@Dongathan-Jong
Copy link
Collaborator

Dongathan-Jong commented Sep 4, 2024

Hey there! This is so cool! I love how they're all solvable! I will forward this to Alex for next steps/approval. If needed, you may be asked to increase the complexity of your piece as per our submission guidelines!

Also, please change your PR name to Projectname-Yourname. For example: GameDrawer-Yash

@Dongathan-Jong Dongathan-Jong self-assigned this Sep 4, 2024
Copy link
Member

@qcoral qcoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really clean implementation! A couple things:

  1. Could you include some sort of description within your code explaining what it is // what it does?
  2. I think some more flair around the game board would be great! Maybe adding a sudoku title or something?

@Yash00241 Yash00241 changed the title Game Drawer Sudoku Game Drawer Sep 10, 2024
@Yash00241 Yash00241 changed the title Sudoku Game Drawer Sudoku Game Drawer - Yash Vardhan Niranjan Sep 10, 2024
@Yash00241
Copy link
Author

Hey there! This is so cool! I love how they're all solvable! I will forward this to Alex for next steps/approval. If needed, you may be asked to increase the complexity of your piece as per our submission guidelines!

Also, please change your PR name to Projectname-Yourname. For example: GameDrawer-Yash

Hey @Dongathan-Jong You asked me to change the name did it so.
Also a question was asked related to complexity of the game, so you can adjust the difficulty by changing the value of game difficulty in the code it is marked as const difficulty in the first few lines of the code.

Hope it helps =D

Screenshot_10-9-2024_1817_github com

@Yash00241
Copy link
Author

This is a really clean implementation! A couple things:

  1. Could you include some sort of description within your code explaining what it is // what it does?
  2. I think some more flair around the game board would be great! Maybe adding a sudoku title or something?

Got it @qcoral will be doing it ASAP the only thing I want is just a little bit of time as Half-Yearly Examinations are arriving so need to study for them as well :>
Also, I did not get the of changing name. Should I Change the Name of PR or the name of the folder which is requested to be merged into the directory. If t=it is for the folder kindly direct me a little bit that, how do I do it as I don't know how I can change files during a Pull Request.

@Yash00241
Copy link
Author

Got it and did it, completed all the given tasks :)

@BrightTheBackpack
Copy link
Member

btw "If needed, you may be asked to increase the complexity of your piece as per our submission guidelines!" isn't talking about the game difficulty, just the complexity of the actual art piece

@qcoral qcoral added dev development of blot and removed dev development of blot labels Sep 17, 2024
Copy link
Member

@qcoral qcoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! You're almost there, if you could just add more visual flair to the piece (maybe a frame?? or something else), I think that would really help the piece

@Dongathan-Jong
Copy link
Collaborator

Just an update, I will be closing this PR! Please create a new PR once you have updated your art! We are doing this due to new management of the PR system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants