-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sudoku Game Drawer - Yash Vardhan Niranjan #888
Conversation
@Yash00241 is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey there! This is so cool! I love how they're all solvable! I will forward this to Alex for next steps/approval. If needed, you may be asked to increase the complexity of your piece as per our submission guidelines! Also, please change your PR name to Projectname-Yourname. For example: GameDrawer-Yash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really clean implementation! A couple things:
- Could you include some sort of description within your code explaining what it is // what it does?
- I think some more flair around the game board would be great! Maybe adding a sudoku title or something?
Hey @Dongathan-Jong You asked me to change the name did it so. Hope it helps =D |
Got it @qcoral will be doing it ASAP the only thing I want is just a little bit of time as Half-Yearly Examinations are arriving so need to study for them as well :> |
Got it and did it, completed all the given tasks :) |
btw "If needed, you may be asked to increase the complexity of your piece as per our submission guidelines!" isn't talking about the game difficulty, just the complexity of the actual art piece |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! You're almost there, if you could just add more visual flair to the piece (maybe a frame?? or something else), I think that would really help the piece
Just an update, I will be closing this PR! Please create a new PR once you have updated your art! We are doing this due to new management of the PR system. |
Write a short description about your art piece, such as what your artwork represents and your experience drawing it!
Next, make sure you go through each item in the following checklist. Delete this line after!
Math.random()
(See the documentation on randomness)If you used based your art on something else, used a tutorial, or remixed it from something else, please link it here:
Lastly, link a picture of your art piece here: