Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baseballfield-Ventengo #830

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Baseballfield-Ventengo #830

wants to merge 30 commits into from

Conversation

Ventengo1
Copy link

@Ventengo1 Ventengo1 commented Aug 15, 2024

My art piece is of a baseball field. I included the infield with the four bases as well as the pitchers mound. I also included the outfield fence and made sure to leave room past it just like in a real field. I have some experience coding in Java script but more in other languages. I learned a lot while coding this project.

pic1

  • I have read the steps to getting a blot
  • I am submitting art that...
    • is algorithmically generated (will meaningfully change each time the program is run)
    • is your own work that is not copied from somewhere else
    • doesn't call Math.random() (See the documentation on randomness)
    • is drawable on Blot itself (doesn't have lines overlap more than 5 times)
      • Doesn't overlap lines more than 5 times
      • Fits in the working area of 125x125mm
      • Doesn't rely on colour to look good

If you used based your art on something else, used a tutorial, or remixed it from something else, please link it here: https://blot.hackclub.com/editor?guide=start

@Ventengo1
Copy link
Author

Ventengo1 commented Aug 18, 2024

IMG_3017

this is the image just hard to see in dark mode because it is black.

Copy link
Member

@maxwofford maxwofford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like this piece is generative!

@Ventengo1
Copy link
Author

What do you mean by generative? I have lots of variables throughout the code which can be changed altering the image. For example the large curve on the left side of the image can be flipped or the amount of arc can be changed layering how it would look. Also the size of the squares can also be changed altering the look.

@Ventengo1
Copy link
Author

There are more examples too with the positions of the squares, the size of the circle in the middle, and more

@qcoral
Copy link
Member

qcoral commented Aug 21, 2024

Hey, I did a check and this is indeed generative, but 2 things:

  1. Could you move the variables to the top so that they can easily be changed?
  2. This drawing is a little simple, could you work on it more?

I'll swing back around later, thanks for the wait!

@Ventengo1
Copy link
Author

Updated code by moving all variables to top and adding another element which is mountains. I did this after one of my favorite baseball teams the Colorado Rockies.

@Ventengo1
Copy link
Author

Ventengo1 commented Aug 21, 2024

Updated the PR with new code but how do I add the image and get rid of the old one in the Pull request.
pic1

Copy link
Member

@qcoral qcoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better, but still could use some more work. Also, can you move the variables at the top? Makes it much easier for someone to see the different generations of your artwork!

@Ventengo1
Copy link
Author

All the variables are at the top

@Ventengo1
Copy link
Author

Ventengo1 commented Aug 22, 2024

Moved all variables to top and added more to code.
Adde some seats in center field just like in an actual baseball stadium and I added a line between the infield and the bases as well as an baseline.
pic1

@Ventengo1 Ventengo1 requested a review from qcoral August 23, 2024 15:16
@Ventengo1
Copy link
Author

Just updated code and polished it up.
pic1

Copy link

vercel bot commented Aug 23, 2024

@Ventengo1 is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

@Ventengo1
Copy link
Author

How do I chance the pic 1, pic 2, and pic 3, file to the new images

@Ventengo1
Copy link
Author

Just updated code:
pic1

@Ventengo1
Copy link
Author

pic2

@Ventengo1
Copy link
Author

pic3

@Ventengo1
Copy link
Author

Just updated with more
pic2
pic1
pic3
random variables

@Ventengo1
Copy link
Author

Ventengo1 commented Aug 23, 2024

Polished up code and now I feel it looks good.
pic1
pic2
pic3

@Ventengo1 Ventengo1 marked this pull request as draft August 23, 2024 19:53
@Ventengo1 Ventengo1 marked this pull request as ready for review August 23, 2024 19:55
@Ventengo1
Copy link
Author

Just updated code by adding word 'Rockies' to it.
image

@Ventengo1
Copy link
Author

image (1)

Copy link
Member

@qcoral qcoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is getting there!! But there's still a ton of overlapping & generally unpolished parts. Can you try and clean things up? I'm specifically looking at the players, as I'm pretty sure they aren't so uncoordinated in real baseball :)

@Ventengo1
Copy link
Author

Just updated code and made it look a lot cleaner.
image (2)

@Ventengo1
Copy link
Author

Made it look a lot more realistic by adding people at the bases and on the field

@EmperorNumerius
Copy link
Collaborator

Hi there,
This is a cool piece of artwork but it needs to have less overlapping
You are well on your way to having a blot. howvever its a bit simple and overlaps quite a lot

@EmperorNumerius EmperorNumerius self-assigned this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants