Skip to content

fix: don't disable HERMES #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
e271828- merged 2 commits into from
Aug 19, 2025
Merged

fix: don't disable HERMES #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8359528
fix: don't disable HERMES
CAMOBAP Aug 19, 2025
d83f860
ci: use Xcode 16.4 for macos tests
CAMOBAP Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ jobs:
with:
java-version: 17
distribution: adopt
- if: contains(matrix.os, 'macos')
run: sudo xcode-select -s /Applications/Xcode_16.4.app
- run: |
npm run example -- --pm ${{ matrix.pm }}
working-directory: react-native-hcaptcha
Expand Down
6 changes: 3 additions & 3 deletions __scripts__/generate-example.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ function main({ cliName, projectRelativeProjectPath, projectName, projectTemplat

// Run the project initialization command
console.log(`Running command: ${createCommand}`);
execSync(createCommand.join(' '), { stdio: 'inherit', shell: true, env: { ...process.env, PATH: cleanPathEnv(), USE_HERMES: 0 } });
execSync(createCommand.join(' '), { stdio: 'inherit', shell: true, env: { ...process.env, PATH: cleanPathEnv() } });

const projectPath = path.join(process.cwd(), projectRelativeProjectPath);
const packageManagerOptions = { stdio: 'inherit', cwd: projectPath };
Expand All @@ -143,7 +143,7 @@ function main({ cliName, projectRelativeProjectPath, projectName, projectTemplat
// Install dependencies
const isHcaptchaLinked = checkHcaptchaLinked();
const mainPackage = '@hcaptcha/react-native-hcaptcha';
const mainPackagePath = `${path.dirname(projectRelativeProjectPath)}/react-native-hcaptcha`;
const mainPackagePath = path.join(path.dirname(projectRelativeProjectPath), path.basename(process.cwd()));
const peerPackages = 'react-native-modal react-native-webview';
const devPackages = 'typescript @babel/preset-env';

Expand All @@ -167,7 +167,7 @@ function main({ cliName, projectRelativeProjectPath, projectName, projectTemplat

// iOS: pod install
if (platform() === 'darwin') {
const podOptions = { stdio: 'inherit', cwd: path.join(projectPath, 'ios'), env: { ...process.env, USE_HERMES: 0 } };
const podOptions = { stdio: 'inherit', cwd: path.join(projectPath, 'ios') };
execSync('bundle install', podOptions);
execSync('bundle exec pod install', podOptions);
}
Expand Down
Loading