Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace X509 with scitokens #421

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

eagoetz
Copy link
Collaborator

@eagoetz eagoetz commented Jan 30, 2025

This PR replaces X509 with scitokens. This may requires some downstream changes to the LIGO summary pages scripts

@eagoetz eagoetz added this to the 2.3.0 milestone Jan 30, 2025
@eagoetz eagoetz force-pushed the use-scitokens branch 4 times, most recently from 01eb398 to e8e54b8 Compare January 30, 2025 21:54
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.20%. Comparing base (720bd0c) to head (624f6cd).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
gwsumm/batch.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #421      +/-   ##
==========================================
- Coverage   49.64%   49.20%   -0.45%     
==========================================
  Files          60       60              
  Lines        8823     8779      -44     
==========================================
- Hits         4380     4319      -61     
- Misses       4443     4460      +17     
Flag Coverage Δ
Linux 49.20% <85.71%> (-0.45%) ⬇️
macOS 49.20% <85.71%> (?)
python3.10 49.20% <85.71%> (-0.45%) ⬇️
python3.11 49.20% <85.71%> (-0.45%) ⬇️
python3.9 49.20% <85.71%> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eagoetz eagoetz marked this pull request as ready for review February 3, 2025 21:11
@iaraota
Copy link
Collaborator

iaraota commented Feb 4, 2025

This version of batch is running in detchar.dev:

https://ldas-jobs.ligo-la.caltech.edu/~detchar.dev/summary/day/20250204/

@iaraota iaraota self-requested a review February 6, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants