Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix for css cardinality bug #177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BioPhoton
Copy link

this is a hotfix for some ionic defaults that override the ion-autocomplete stylings if we reference css order in index like following:

  1. lib.bundle.css => all css files in lib bundled together and minified
  2. app.bundle.css => all css files that are app depending (starting with ionic bundle) bundled together and minified

this is a hotfix for some ionic defaults that override the ion-autocomplete stylings if we reference css order in index like following:

1. lib.bundle.css => all css files in lib bundled together and minified
2. app.bundle.css => all css files that are app depending (starting with ionic bundle) bundled together and minified
@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.882% when pulling 0541d95 on BioPhoton:patch-1 into 5f10460 on guylabs:master.

@guylabs guylabs added this to the 0.3.3 milestone May 17, 2016
@guylabs guylabs self-assigned this May 17, 2016
@guylabs
Copy link
Owner

guylabs commented May 17, 2016

Hi @BioPhoton,

thanks for creating the pull request! Could you maybe execute the grunt build task such that the dist folder also gets updated? Then I can merge it with the master easily.

Thanks a lot and regards,

Guy

@guylabs guylabs modified the milestones: 0.4.0, 0.3.3 Oct 27, 2016
@guylabs
Copy link
Owner

guylabs commented Oct 27, 2016

Hi @BioPhoton,

I just moved this to 0.4.0 as there was no update from your side. Is this still needed in the Ionic 1.3.x version?

Thanks and regards,

Guy

@guylabs
Copy link
Owner

guylabs commented Feb 23, 2017

Hi @BioPhoton

could you maybe test this with the latest master if this is still needed? As there we now use the Ionic 1.3.2 version.

Thanks and regards,

Guy

@guylabs guylabs assigned BioPhoton and unassigned guylabs Feb 23, 2017
@guylabs guylabs modified the milestones: 0.4.1, 0.4.0 Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants