Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent showing popup if disabled #168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dxe4
Copy link

@dxe4 dxe4 commented Apr 27, 2016

hi do you think this is a reasonable change?
having a disabled input on the browser prevents the popup from showing, but doesn't seem to prevent it on android (crosswalk).

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.02%) to 73.864% when pulling 5529e42 on papaloizouc:master into 5f10460 on guylabs:master.

@guylabs
Copy link
Owner

guylabs commented Apr 28, 2016

Hi @papaloizouc,

thanks for the contribution. But could you maybe create some tests for it and then also run the grunt build task such that everything is built properly?

Thanks and regards,

Guy

@guylabs guylabs added this to the 0.3.3 milestone Sep 24, 2016
@guylabs guylabs modified the milestones: 0.4.0, 0.3.3 Oct 27, 2016
@guylabs
Copy link
Owner

guylabs commented Oct 27, 2016

Hi @papaloizouc,

I just moved this to 0.4.0 as there was no update from your side. Is this still needed in the Ionic 1.3.x version?

Thanks and regards,

Guy

@guylabs
Copy link
Owner

guylabs commented Feb 23, 2017

Hi @papaloizouc

could you maybe test this with the latest master if this is still needed? As there we now use the Ionic 1.3.2 version.

Thanks and regards,

Guy

@guylabs guylabs modified the milestones: 0.4.1, 0.4.0 Feb 24, 2017
@dxe4
Copy link
Author

dxe4 commented Mar 22, 2017

hi sorry for the delay. i tested on 0.4 having an <input disabled="disabled"> still seems to allow the popup to open. Mostly from my side the values of the auto-complete depend on what you choose on a dropdown, so i have the auto-complete disabled until you select something. I'll try to find some time to write tests for this. Meanwhile it looks like i'm the only person who needed that feature so probably not a big deal.

@guylabs
Copy link
Owner

guylabs commented Mar 22, 2017

HI @papaloizouc

ok thanks for the test. I think some tests would be nice, and then I can merge it to master.

Thanks and regards

Guy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants