-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor control station/keypad handling for RA3/QSX #114
base: dev
Are you sure you want to change the base?
Conversation
@danaues this is working well against my QSX processor and a Caseta Bridge Pro, mind giving it a try against your RA3? Corresponding HA Core is in this branch: https://github.com/cbw/homeassistant-core/tree/keypad_refactor |
Yes for sure. I’ll start testing this evening. |
@cbw only 1 issue i'm seeing so far. The device triggers for the keypads and picos aren't functioning under the current ha integration for RA3/HWQSX. They appear to be working fine for caseta. ** just realized I'm running the current dev HA. I'll switch to your branch and re-test. |
Device triggers confirmed not working for picos and keypads. Also getting some naming duplication in the devices. Each entity is still getting it's own device, instead of being cascaded under 1 keypad device, containing all the leds, buttons. The keypad naming isn't giving me enough info to know which one it is. I'll do some more extensive testing this evening. |
@danaues the Caseta working makes sense, its Picos are following the existing codepath. Only the "LEAP2" (need a name for the RA3/QSX flavor of LEAP!) devices follow the new code path. Could you download diagnostics for the RA3 integration and drop that to me on Discord so I can see how it's discovering your system so I can figure out the naming? What's your event trigger config look like for Picos and keypads on RA3? If you go into Developer Tools > Events > subscribe to lutron_caseta_button_events do you see them firing? I was able to successfully test RA3 keypads and Picos through the Lutron app (unfortunately don't have any physical hardware other than a processor yet), but they all fired ok, I suspect it's just the automations you're using are looking for something different. |
@cbw, maybe you should mark this PR as a draft for now, until we've got it all tested |
@danaues I think things are fine on the pylutron side, but no point in merging until it's working end to end. I'll revert it to draft. |
The way keypad button and button LED handling for RA3/HomeWorks QSX extended the Castea data structures in ways that were not straightforward, and had a number of kluges (like stuffing a bunch of data in the name field with underscore delimiters).
This PR refactors the handling of control station devices. It places the control station device (e.g. keypad) into the device tree, and then button groups, buttons, and LEDs are children to that device. This will be unpacked in Home Assistant to create the appropriate devices for keypads, and entities under them for buttons and button LEDs.
These changes do not impact Pico remotes on Caseta. Caseta Pico device handling will require some thought as it will be a breaking change, but would logically fall into this new model.
Tested under current Home Assistant Core dev branch and existing Caseta functionality is unaffected.
Tested successfully against both Home Assistant Core dev branch (doesn't break existing capabilities) as well as my pending HA Core changes to enable this functionality.