Completion #53
Completion #53
Conversation
| // TODO: return item type. | ||
| // TODO: support fetching item description. | ||
| for _, wd := range workspace.Files { | ||
| codePos := token.Pos(position) | ||
| // current position: = wd.FileSet.Position(codePos).String() | ||
| enclosingPath, _ := astutil.PathEnclosingInterval(wd.File, codePos, codePos+1) |
There was a problem hiding this comment.
Nifty! I was about to have to write this
src/go/languageservice/workspace.go
Outdated
| switch x := enclosingNode.(type) { | ||
|
|
||
| // for function declarations, get all their locals declared before codePos | ||
| case *ast.FuncDecl: |
There was a problem hiding this comment.
Does this still work with top level constructs like functions, types, vars, etc?
There was a problem hiding this comment.
Currently, I am handling only functions and their statements.
src/go/languageservice/workspace.go
Outdated
| if(ins.Pos() >= codePos) { | ||
| continue; | ||
| } | ||
| switch insCasted := ins.(type) { |
There was a problem hiding this comment.
You might be able to do this more simply with ast.Walk
There was a problem hiding this comment.
Ok, thanks! I'll take a look at it.
There was a problem hiding this comment.
I rewritten the code to use ast.Walk, currently I am supporting only variable definitions (local for current function and global), I'll work on supporting types & function definitions etc.
| // TODO: take into account context. | ||
| // TODO: support locals. | ||
|
|
||
| // TODO: support other node types. | ||
| // TODO: return item type. | ||
| // TODO: support fetching item description. | ||
| for _, wd := range workspace.Files { |
There was a problem hiding this comment.
Note that this should eventually look at just the current file as opposed to looping through all files... but I was lazy :)
There was a problem hiding this comment.
Oh, ok, I'll change it.
There was a problem hiding this comment.
No need to do this now, just a note.
I think I found quite a good way to get names visible in a specific context. For now I added support for locals of enclosing functions, defined before current position in code.
Addresses: #49 and #50