Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Refactor Rollup recipe #2503

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

silvenon
Copy link
Contributor

Nothing extra is needed to use Rollup with gulp, so this refactors the
recipe to use Rollup's JavaScript API directly.

Nothing extra is needed to use Rollup with gulp, so this refactors the
recipe to use Rollup's JavaScript API directly.
@silvenon
Copy link
Contributor Author

silvenon commented Oct 18, 2020

Alternatively, I could add this next to the rollup-stream example, if you think it's useful to keep that one. But it's best to use tools directly unless it's inconvenient.

@phated
Copy link
Member

phated commented Oct 19, 2020

I believe this recipe should describe both:

  1. Rollup's normal JS API, which should be preferred if you don't need to apply other stream transforms
  2. The new official stream API: https://www.npmjs.com/package/@rollup/stream if you do need to apply more stream transforms.

I think we can include both in this recipe.

@phated
Copy link
Member

phated commented Oct 21, 2020

@silvenon I also think this recipe should just be called "Bundling JavaScript", since it will be the recommended way to include bundling inside your gulpfiles.

@silvenon
Copy link
Contributor Author

silvenon commented Nov 5, 2020

I started working on this again. My plan is to rename this to "Using Module Bundlers" instead because I also want to add webpack and esbuild, both of which support other bundling other assets, not just JavaScript. I'll finish Rollup in the following days and as separate PRs I'll add other bundlers as well.

@phated
Copy link
Member

phated commented Nov 5, 2020

@silvenon I think that is a great plan! Thank you for updating us.

@phated
Copy link
Member

phated commented Apr 2, 2021

@silvenon are you still planning to complete the above changes?

@silvenon
Copy link
Contributor Author

No, sorry, I lost my drive for some reason. 😔 I'll open a new PR once I get it back.

@silvenon silvenon closed this Apr 24, 2021
@phated
Copy link
Member

phated commented May 3, 2021

Thanks for letting me know! I'd like to re-open and pick this up myself. And thank you for the work you put in here already ❤️

@phated phated reopened this May 3, 2021
@phated phated self-assigned this May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants