Dockerfile updates - #3
Open
tianyilim wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Dockerfile to use ROS Noetic along with an updated Ceres version and changes to better support Python3. In addition, the README has been updated with new Docker build and run instructions.
- Update base image from ROS Kinetic to ROS Noetic and update Ceres version.
- Adjust package dependencies to use Python3 and add essential utilities.
- Revise README documentation to reflect these changes.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docker/Dockerfile | Updated base image, Ceres version, and dependencies for ROS Noetic. |
| README.md | Added Docker build and run instructions for the updated Dockerfile. |
Comments suppressed due to low confidence (1)
README.md:14
- The docker run command refers to the image as 'vins_fusion', but the build command tags the image as 'vins-fusion'. Please update the run command to use the correct image name for consistency.
docker run -it vins_fusion
guisoares9
reviewed
Jun 4, 2025
Co-authored-by: Guilherme Soares Silvestre <55659910+guisoares9@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the Dockerfile to use ROS Noetic.