Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitAuto: [FEATURE] Preserve original message for merge conflict resolutions +semver: minor #114

Merged
merged 35 commits into from
Dec 12, 2024

Conversation

gitauto-ai[bot]
Copy link
Contributor

@gitauto-ai gitauto-ai bot commented Nov 7, 2024

Resolves #113

What is the feature

Implement functionality in the dotnet-aicommitmessage tool to preserve original commit messages that follow the auto-generated format used during merge conflict resolutions.

Why we need the feature

Currently, the tool replaces all commit messages generated via the ChatGPT API (LLM models), which can inadvertently modify the intended context of merge conflict resolutions. Preserving the original messages ensures a clear and accurate version history, maintaining the context and intent behind merge conflict resolutions.

How to implement and why

  1. Pattern Detection: Utilize C# regular expressions to detect if a commit message matches the predefined auto-generated pattern for merge conflict resolutions.

  2. Bypass API Generation: If a commit message matches the merge conflict resolution pattern, bypass the ChatGPT API and retain the original message.

  3. Integration: Modify the existing commit message processing workflow to include the detection step before deciding whether to generate a new message or preserve the original.

  4. Unit Testing: Add comprehensive unit tests to verify the correct detection of merge conflict resolution patterns and ensure that messages are preserved or processed as intended based on their pattern.

This step-by-step approach ensures that only relevant messages are preserved while others continue to leverage the AI-powered commit message generation.

About backward compatibility

This feature introduces new pattern detection logic without altering the existing commit message generation workflows for messages that do not match the merge conflict pattern. Therefore, existing functionality remains unaffected, ensuring backward compatibility.

Test these changes locally

git checkout -b gitauto/issue-113-347f3d44-b7bf-48ef-97fb-2935758325ab
git pull origin gitauto/issue-113-347f3d44-b7bf-48ef-97fb-2935758325ab

Copy link
Contributor

coderabbitai bot commented Nov 7, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

deepsource-io bot commented Nov 7, 2024

Here's the code health analysis summary for commits 097ec97..8ad567c. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Test coverage LogoTest coverage✅ Success
🎯 2 occurences resolved
View Check ↗
DeepSource Secrets LogoSecrets✅ SuccessView Check ↗
DeepSource Docker LogoDocker✅ SuccessView Check ↗
DeepSource C# LogoC#✅ SuccessView Check ↗

Code Coverage Report

MetricAggregateC#
Branch Coverage11.8% (up 3.7% from main)11.8% (up 3.7% from main)
Condition Coverage11.8% (up 3.7% from main)11.8% (up 3.7% from main)
Composite Coverage15% (up 5.3% from main)15% (up 5.3% from main)
Line Coverage15.9% (up 5.7% from main)15.9% (up 5.7% from main)
New Branch Coverage50%50%
New Condition Coverage50%50%
New Composite Coverage50%50%
New Line Coverage50%50%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 7, 2024
Copy link
Contributor Author

gitauto-ai bot commented Nov 7, 2024

Committed the Check Run Build error fix! Running it again...

Copy link
Contributor Author

gitauto-ai bot commented Nov 7, 2024

Committed the Check Run linter-check error fix! Running it again...

Copy link
Contributor Author

gitauto-ai bot commented Nov 7, 2024

Committed the Check Run Deep Source Coverage report error fix! Running it again...

Copy link
Contributor Author

gitauto-ai bot commented Nov 7, 2024

Committed the Check Run linter-check error fix! Running it again...

Copy link
Contributor Author

gitauto-ai bot commented Nov 7, 2024

Committed the Check Run Deep Source Coverage report error fix! Running it again...

Copy link
Contributor Author

gitauto-ai bot commented Nov 7, 2024

Committed the Check Run Analyze (csharp) error fix! Running it again...

@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 7, 2024
Copy link
Contributor Author

gitauto-ai bot commented Nov 7, 2024

Committed the Check Run Analyze (csharp) error fix! Running it again...

@gstraccini gstraccini bot added enhancement New feature or request gitauto GitAuto label to trigger the app in a issue. good first issue Good for newcomers hacktoberfest Participation in the Hacktoberfest event help wanted Extra attention is needed 🕒 low effort A task that can be completed in a few minutes labels Nov 7, 2024
@guibranco guibranco removed the 🚦 awaiting triage Items that are awaiting triage or categorization label Dec 12, 2024
@guibranco
Copy link
Owner

@gstraccini linter

Copy link
Contributor

gstraccini bot commented Dec 12, 2024

I'm sorry @guibranco, I can't do that. Command not found. 🥺

@guibranco
Copy link
Owner

@gstraccini csharpier

Copy link
Contributor

gstraccini bot commented Dec 12, 2024

Running CSharpier on this branch! 🔧

Copy link
Contributor

gstraccini bot commented Dec 12, 2024

CSharpier result:

Formatted 17 files in 545ms.

@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 12, 2024
@guibranco guibranco enabled auto-merge (squash) December 12, 2024 18:19
Copy link

Infisical secrets check: ✅ No secrets leaked!

💻 Scan logs
6:21PM INF scanning for exposed secrets...
6:21PM INF 156 commits scanned.
6:21PM INF scan completed in 94.2ms
6:21PM INF no leaks found

@guibranco
Copy link
Owner

@gstraccini bypass codacy

Copy link
Contributor

gstraccini bot commented Dec 12, 2024

I'm sorry @guibranco, I can't do that. Command not found. 🥺

Copy link

sonarcloud bot commented Dec 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@guibranco
Copy link
Owner

@gstraccini codacy bypass

Copy link
Contributor

gstraccini bot commented Dec 12, 2024

Bypassing the Codacy analysis for this pull request! ⚠️

@guibranco guibranco merged commit 53d30c2 into main Dec 12, 2024
24 of 25 checks passed
@guibranco guibranco deleted the gitauto/issue-113-347f3d44-b7bf-48ef-97fb-2935758325ab branch December 12, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 bot Automated processes or integrations enhancement New feature or request gitauto GitAuto label to trigger the app in a issue. good first issue Good for newcomers hacktoberfest Participation in the Hacktoberfest event help wanted Extra attention is needed 🕒 low effort A task that can be completed in a few minutes size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Preserve original message for merge conflict resolutions
1 participant