Remove Network Calls From Validate Tests #13891

JamieB-gu · 2025-05-01T12:39:40Z

These tests were fetching JSON data to validate from frontend directly, via the network. This change switches to using local fixture files for this instead. Advantages include:

Faster tests, due to bundling the data rather than retrieving it from the network.
No side-effects in the tests, which means that data changing on the frontend side won't cause the tests to fail unexpectedly on an unrelated change.
No possibility of network issues failing the tests on an arbitrary change, as occurred in Bump @storybook/addon-webpack5-compiler-babel from 3.0.5 to 3.0.6 in the babel group #13870.

These tests were fetching JSON data to validate from frontend directly, via the network. This change switches to using local fixture files for this instead. Advantages include: - Faster tests, due to bundling the data rather than retrieving it from the network. - No side-effects in the tests, which means that data changing on the frontend side won't cause the tests to fail unexpectedly on an unrelated change. - No possibility of network issues failing the tests on an arbitrary change.

github-actions · 2025-05-01T12:39:51Z

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

github-actions · 2025-05-01T12:43:43Z

Deploy build 18202 of `dotcom:rendering-all` to CODE

All deployment options

From guardian/actions-riff-raff.

github-actions · 2025-05-01T12:44:59Z

Size Change: 0 B

Total Size: 973 kB

ℹ️ View Unchanged

Filename	Size
`dotcom-rendering/dist/1032.client.web.********************.js`	3.31 kB
`dotcom-rendering/dist/117.client.web.********************.js`	2.87 kB
`dotcom-rendering/dist/1244.client.web.********************.js`	16.5 kB
`dotcom-rendering/dist/1656.client.web.********************.js`	50.2 kB
`dotcom-rendering/dist/2045.client.web.********************.js`	2.63 kB
`dotcom-rendering/dist/2161.client.web.********************.js`	3.88 kB
`dotcom-rendering/dist/223.client.web.********************.js`	527 B
`dotcom-rendering/dist/2270.client.web.********************.js`	3.65 kB
`dotcom-rendering/dist/2309.client.web.********************.js`	3.27 kB
`dotcom-rendering/dist/2345.client.web.********************.js`	3.38 kB
`dotcom-rendering/dist/2360.client.web.********************.js`	19.9 kB
`dotcom-rendering/dist/2375.client.web.********************.js`	2.77 kB
`dotcom-rendering/dist/302.client.web.********************.js`	8.84 kB
`dotcom-rendering/dist/3226.client.web.********************.js`	2.85 kB
`dotcom-rendering/dist/3292.client.web.********************.js`	2.11 kB
`dotcom-rendering/dist/3485.client.web.********************.js`	4.67 kB
`dotcom-rendering/dist/3598.client.web.********************.js`	3.65 kB
`dotcom-rendering/dist/3605.client.web.********************.js`	15.1 kB
`dotcom-rendering/dist/3619.client.web.********************.js`	4.46 kB
`dotcom-rendering/dist/3950.client.web.********************.js`	3.36 kB
`dotcom-rendering/dist/4258.client.web.********************.js`	4.08 kB
`dotcom-rendering/dist/4306.client.web.********************.js`	22.7 kB
`dotcom-rendering/dist/4308.client.web.********************.js`	3.57 kB
`dotcom-rendering/dist/4324.client.web.********************.js`	619 B
`dotcom-rendering/dist/4457.client.web.********************.js`	6.25 kB
`dotcom-rendering/dist/4501.client.web.********************.js`	4.29 kB
`dotcom-rendering/dist/4577.client.web.********************.js`	3.13 kB
`dotcom-rendering/dist/4684.client.web.********************.js`	20.3 kB
`dotcom-rendering/dist/4685.client.web.********************.js`	3.12 kB
`dotcom-rendering/dist/4900.client.web.********************.js`	2.88 kB
`dotcom-rendering/dist/4958.client.web.********************.js`	3.9 kB
`dotcom-rendering/dist/5144.client.web.********************.js`	2.55 kB
`dotcom-rendering/dist/5448.client.web.********************.js`	4.37 kB
`dotcom-rendering/dist/545.client.web.********************.js`	531 B
`dotcom-rendering/dist/5455.client.web.********************.js`	7.15 kB
`dotcom-rendering/dist/547.client.web.********************.js`	5.42 kB
`dotcom-rendering/dist/5612.client.web.********************.js`	7.98 kB
`dotcom-rendering/dist/562.client.web.********************.js`	11.5 kB
`dotcom-rendering/dist/5734.client.web.********************.js`	2.62 kB
`dotcom-rendering/dist/6038.client.web.********************.js`	2.76 kB
`dotcom-rendering/dist/610.client.web.********************.js`	2.67 kB
`dotcom-rendering/dist/6217.client.web.********************.js`	3.75 kB
`dotcom-rendering/dist/6548.client.web.********************.js`	3.29 kB
`dotcom-rendering/dist/6562.client.web.********************.js`	439 B
`dotcom-rendering/dist/6722.client.web.********************.js`	3.03 kB
`dotcom-rendering/dist/6802.client.web.********************.js`	2.51 kB
`dotcom-rendering/dist/6873.client.web.********************.js`	4.13 kB
`dotcom-rendering/dist/695.client.web.********************.js`	4.51 kB
`dotcom-rendering/dist/6966.client.web.********************.js`	3.68 kB
`dotcom-rendering/dist/7116.client.web.********************.js`	23.2 kB
`dotcom-rendering/dist/732.client.web.********************.js`	3.07 kB
`dotcom-rendering/dist/7398.client.web.********************.js`	3.57 kB
`dotcom-rendering/dist/7487.client.web.********************.js`	4.23 kB
`dotcom-rendering/dist/781.client.web.********************.js`	156 B
`dotcom-rendering/dist/7927.client.web.********************.js`	2.77 kB
`dotcom-rendering/dist/8050.client.web.********************.js`	3.1 kB
`dotcom-rendering/dist/8151.client.web.********************.js`	4.17 kB
`dotcom-rendering/dist/8212.client.web.********************.js`	5.04 kB
`dotcom-rendering/dist/8385.client.web.********************.js`	3.88 kB
`dotcom-rendering/dist/8436.client.web.********************.js`	3.63 kB
`dotcom-rendering/dist/8602.client.web.********************.js`	3.39 kB
`dotcom-rendering/dist/8619.client.web.********************.js`	4.44 kB
`dotcom-rendering/dist/864.client.web.********************.js`	3.17 kB
`dotcom-rendering/dist/8942.client.web.********************.js`	4.44 kB
`dotcom-rendering/dist/8985.client.web.********************.js`	11.1 kB
`dotcom-rendering/dist/9018.client.web.********************.js`	3.73 kB
`dotcom-rendering/dist/9135.client.web.********************.js`	3.54 kB
`dotcom-rendering/dist/9209.client.web.********************.js`	2.91 kB
`dotcom-rendering/dist/9376.client.web.********************.js`	2.52 kB
`dotcom-rendering/dist/967.client.web.********************.js`	2.87 kB
`dotcom-rendering/dist/9709.client.web.********************.js`	2.73 kB
`dotcom-rendering/dist/9822.client.web.********************.js`	7.63 kB
`dotcom-rendering/dist/9870.client.web.********************.js`	4.77 kB
`dotcom-rendering/dist/Accessibility-importable.client.web.********************.js`	8.42 kB
`dotcom-rendering/dist/AdBlockAsk-importable.client.web.********************.js`	2.99 kB
`dotcom-rendering/dist/AdPortals-importable.client.web.********************.js`	4.76 kB
`dotcom-rendering/dist/AlreadyVisited-importable.client.web.********************.js`	426 B
`dotcom-rendering/dist/AppsEpic-importable.client.web.********************.js`	3.61 kB
`dotcom-rendering/dist/AppsFooter-importable.client.web.********************.js`	2.69 kB
`dotcom-rendering/dist/AppsLightboxImage-importable.client.web.********************.js`	2.66 kB
`dotcom-rendering/dist/AppsLightboxImageStore-importable.client.web.********************.js`	2.61 kB
`dotcom-rendering/dist/AudioAtomWrapper-importable.client.web.********************.js`	2.76 kB
`dotcom-rendering/dist/AudioPlayerWrapper-importable.client.web.********************.js`	6.61 kB
`dotcom-rendering/dist/AustralianTerritorySwitcher-importable.client.web.********************.js`	4.61 kB
`dotcom-rendering/dist/Branding-importable.client.web.********************.js`	2.89 kB
`dotcom-rendering/dist/braze-web-sdk-core.client.web.********************.js`	67.7 kB
`dotcom-rendering/dist/BrazeMessaging-importable.client.web.********************.js`	1.68 kB
`dotcom-rendering/dist/CalloutBlockComponent-importable.client.web.********************.js`	6.73 kB
`dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.client.web.********************.js`	5.77 kB
`dotcom-rendering/dist/CardCommentCount-importable.client.web.********************.js`	2.67 kB
`dotcom-rendering/dist/Carousel-importable.client.web.********************.js`	6.67 kB
`dotcom-rendering/dist/CarouselForNewsletters-importable.client.web.********************.js`	4.55 kB
`dotcom-rendering/dist/ChartAtom-importable.client.web.********************.js`	539 B
`dotcom-rendering/dist/CommentCount-importable.client.web.********************.js`	2.3 kB
`dotcom-rendering/dist/CrosswordComponent-importable.client.web.********************.js`	2.87 kB
`dotcom-rendering/dist/DiscussionApps-importable.client.web.********************.js`	1.07 kB
`dotcom-rendering/dist/DiscussionMeta-importable.client.web.********************.js`	2.41 kB
`dotcom-rendering/dist/DiscussionWeb-importable.client.web.********************.js`	3.46 kB
`dotcom-rendering/dist/DocumentBlockComponent-importable.client.web.********************.js`	2.85 kB
`dotcom-rendering/dist/Dropdown-importable.client.web.********************.js`	1.72 kB
`dotcom-rendering/dist/EditionSwitcherBanner-importable.client.web.********************.js`	4.42 kB
`dotcom-rendering/dist/EmbedBlockComponent-importable.client.web.********************.js`	3.98 kB
`dotcom-rendering/dist/EnhancePinnedPost-importable.client.web.********************.js`	2.02 kB
`dotcom-rendering/dist/FetchOnwardsData-importable.client.web.********************.js`	1.93 kB
`dotcom-rendering/dist/FilterKeyEventsToggle-importable.client.web.********************.js`	3.71 kB
`dotcom-rendering/dist/FocusStyles-importable.client.web.********************.js`	618 B
`dotcom-rendering/dist/FollowWrapper-importable.client.web.********************.js`	2.53 kB
`dotcom-rendering/dist/FootballMatchesPageWrapper-importable.client.web.********************.js`	7.2 kB
`dotcom-rendering/dist/FootballTablesCompetitionSelect-importable.client.web.********************.js`	3.26 kB
`dotcom-rendering/dist/FooterLabel-importable.client.web.********************.js`	364 B
`dotcom-rendering/dist/FooterReaderRevenueLinks-importable.client.web.********************.js`	3.43 kB
`dotcom-rendering/dist/frameworks.client.web.********************.js`	20.9 kB
`dotcom-rendering/dist/FrontSubNav-importable.client.web.********************.js`	7.51 kB
`dotcom-rendering/dist/GetCricketScoreboard-importable.client.web.********************.js`	6.29 kB
`dotcom-rendering/dist/GetMatchNav-importable.client.web.********************.js`	11.5 kB
`dotcom-rendering/dist/GetMatchStats-importable.client.web.********************.js`	8.1 kB
`dotcom-rendering/dist/GetMatchTabs-importable.client.web.********************.js`	2.58 kB
`dotcom-rendering/dist/guardian-braze-components-banner.client.web.********************.js`	15.6 kB
`dotcom-rendering/dist/guardian-braze-components-end-of-article.client.web.********************.js`	10.2 kB
`dotcom-rendering/dist/GuideAtomWrapper-importable.client.web.********************.js`	782 B
`dotcom-rendering/dist/index.client.web.********************.js`	46.2 kB
`dotcom-rendering/dist/InstagramBlockComponent-importable.client.web.********************.js`	2.9 kB
`dotcom-rendering/dist/InteractiveAtomMessenger-importable.client.web.********************.js`	854 B
`dotcom-rendering/dist/InteractiveBlockComponent-importable.client.web.********************.js`	8.82 kB
`dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.client.web.********************.js`	3.76 kB
`dotcom-rendering/dist/KeyEventsCarousel-importable.client.web.********************.js`	5.69 kB
`dotcom-rendering/dist/KnowledgeQuizAtom-importable.client.web.********************.js`	3.19 kB
`dotcom-rendering/dist/LatestLinks-importable.client.web.********************.js`	7.95 kB
`dotcom-rendering/dist/LightboxHash-importable.client.web.********************.js`	435 B
`dotcom-rendering/dist/LightboxLayout-importable.client.web.********************.js`	6.56 kB
`dotcom-rendering/dist/LiveBlogEpic-importable.client.web.********************.js`	3.56 kB
`dotcom-rendering/dist/LiveblogGutterAskWrapper-importable.client.web.********************.js`	2.49 kB
`dotcom-rendering/dist/LiveblogNotifications-importable.client.web.********************.js`	4.84 kB
`dotcom-rendering/dist/Liveness-importable.client.web.********************.js`	4.71 kB
`dotcom-rendering/dist/LoopVideo-importable.client.web.********************.js`	3.54 kB
`dotcom-rendering/dist/ManyNewsletterSignUp-importable.client.web.********************.js`	7.68 kB
`dotcom-rendering/dist/MapEmbedBlockComponent-importable.client.web.********************.js`	6.04 kB
`dotcom-rendering/dist/Metrics-importable.client.web.********************.js`	2.7 kB
`dotcom-rendering/dist/MostViewedFooter-importable.client.web.********************.js`	3.85 kB
`dotcom-rendering/dist/MostViewedFooterData-importable.client.web.********************.js`	5.98 kB
`dotcom-rendering/dist/MostViewedRightWithAd-importable.client.web.********************.js`	5.25 kB
`dotcom-rendering/dist/OnwardsUpper-importable.client.web.********************.js`	5.37 kB
`dotcom-rendering/dist/PersonalityQuizAtom-importable.client.web.********************.js`	3.35 kB
`dotcom-rendering/dist/ProfileAtom-importable.client.web.********************.js`	545 B
`dotcom-rendering/dist/ProfileAtomWrapper-importable.client.web.********************.js`	805 B
`dotcom-rendering/dist/PulsingDot-importable.client.web.********************.js`	751 B
`dotcom-rendering/dist/QandaAtom-importable.client.web.********************.js`	542 B
`dotcom-rendering/dist/ReaderRevenueDev-importable.client.web.********************.js`	470 B
`dotcom-rendering/dist/readerRevenueDevUtils.client.web.********************.js`	1.7 kB
`dotcom-rendering/dist/RelativeTime-importable.client.web.********************.js`	2.56 kB
`dotcom-rendering/dist/RichLinkComponent-importable.client.web.********************.js`	6.15 kB
`dotcom-rendering/dist/ScrollableFeature-importable.client.web.********************.js`	6.62 kB
`dotcom-rendering/dist/ScrollableHighlights-importable.client.web.********************.js`	7.27 kB
`dotcom-rendering/dist/ScrollableMedium-importable.client.web.********************.js`	2.11 kB
`dotcom-rendering/dist/ScrollableSmall-importable.client.web.********************.js`	2.17 kB
`dotcom-rendering/dist/SecureSignup-importable.client.web.********************.js`	4.21 kB
`dotcom-rendering/dist/SendTargetingParams-importable.client.web.********************.js`	2.22 kB
`dotcom-rendering/dist/sentry.client.web.********************.js`	802 B
`dotcom-rendering/dist/SetABTests-importable.client.web.********************.js`	3.91 kB
`dotcom-rendering/dist/SetAdTargeting-importable.client.web.********************.js`	488 B
`dotcom-rendering/dist/ShareButton-importable.client.web.********************.js`	2.18 kB
`dotcom-rendering/dist/shimport.client.web.********************.js`	2.8 kB
`dotcom-rendering/dist/ShowHideContainers-importable.client.web.********************.js`	899 B
`dotcom-rendering/dist/ShowMore-importable.client.web.********************.js`	919 B
`dotcom-rendering/dist/SignInGateMain.client.web.********************.js`	4.35 kB
`dotcom-rendering/dist/SignInGateMainCheckoutComplete.client.web.********************.js`	5.46 kB
`dotcom-rendering/dist/SignInGateSelector-importable.client.web.********************.js`	6.67 kB
`dotcom-rendering/dist/SlideshowCarousel-importable.client.web.********************.js`	4.56 kB
`dotcom-rendering/dist/SlotBodyEnd-importable.client.web.********************.js`	4.91 kB
`dotcom-rendering/dist/SpotifyBlockComponent-importable.client.web.********************.js`	5.8 kB
`dotcom-rendering/dist/StickyBottomBanner-importable.client.web.********************.js`	4.04 kB
`dotcom-rendering/dist/SubNav-importable.client.web.********************.js`	2.44 kB
`dotcom-rendering/dist/TableOfContents-importable.client.web.********************.js`	3.52 kB
`dotcom-rendering/dist/TimelineAtom-importable.client.web.********************.js`	1.23 kB
`dotcom-rendering/dist/Titlepiece-importable.client.web.********************.js`	13.6 kB
`dotcom-rendering/dist/TopBar-importable.client.web.********************.js`	8.85 kB
`dotcom-rendering/dist/TopBarSupport-importable.client.web.********************.js`	2.49 kB
`dotcom-rendering/dist/TweetBlockComponent-importable.client.web.********************.js`	1.13 kB
`dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.client.web.********************.js`	2.92 kB
`dotcom-rendering/dist/VideoFacebookBlockComponent-importable.client.web.********************.js`	6.06 kB
`dotcom-rendering/dist/VineBlockComponent-importable.client.web.********************.js`	3.32 kB
`dotcom-rendering/dist/YoutubeBlockComponent-importable.client.web.********************.js`	843 B

_{compressed-size-action}

prout-bot · 2025-05-12T10:14:00Z

Overdue on PROD (merged by @JamieB-gu 30 minutes and 6 seconds ago) What's gone wrong?

prout-bot · 2025-05-12T10:22:15Z

Seen on PROD (merged by @JamieB-gu 38 minutes and 21 seconds ago) Please check your changes!

JamieB-gu added this to the Health milestone May 1, 2025

JamieB-gu self-assigned this May 1, 2025

github-actions bot added the dotcom-rendering label May 1, 2025

JamieB-gu added the run_chromatic Runs chromatic when label is applied label May 1, 2025

github-actions bot removed the run_chromatic Runs chromatic when label is applied label May 1, 2025

JamieB-gu requested a review from a team May 6, 2025 12:28

SiAdcock approved these changes May 8, 2025

View reviewed changes

JamieB-gu merged commit a44883d into main May 12, 2025
33 checks passed

JamieB-gu deleted the remove-network-calls-from-validate-tests branch May 12, 2025 09:43

prout-bot added Pending-on-PROD Overdue-on-PROD and removed Pending-on-PROD labels May 12, 2025

prout-bot added Seen-on-PROD and removed Overdue-on-PROD labels May 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove Network Calls From Validate Tests #13891

Remove Network Calls From Validate Tests #13891

Uh oh!

JamieB-gu commented May 1, 2025

Uh oh!

github-actions bot commented May 1, 2025

Uh oh!

github-actions bot commented May 1, 2025

Uh oh!

github-actions bot commented May 1, 2025

Uh oh!

Uh oh!

prout-bot commented May 12, 2025

Uh oh!

prout-bot commented May 12, 2025

Uh oh!

Uh oh!

Remove Network Calls From Validate Tests #13891

Remove Network Calls From Validate Tests #13891

Uh oh!

Conversation

JamieB-gu commented May 1, 2025

Uh oh!

github-actions bot commented May 1, 2025

Uh oh!

github-actions bot commented May 1, 2025

Deploy build 18202 of dotcom:rendering-all to CODE

Uh oh!

github-actions bot commented May 1, 2025

Uh oh!

Uh oh!

prout-bot commented May 12, 2025

Uh oh!

prout-bot commented May 12, 2025

Uh oh!

Uh oh!

Deploy build 18202 of `dotcom:rendering-all` to CODE