-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add crossword layout #13001
Merged
Merged
Add crossword layout #13001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a first pass, it needs work
and use JSdoc for editor assistance
This reverts commit f3b9feb.
Size Change: +1.54 kB (+0.17%) Total Size: 894 kB
ℹ️ View Unchanged
|
Merged
SiAdcock
reviewed
Jan 29, 2025
SiAdcock
reviewed
Jan 29, 2025
SiAdcock
reviewed
Jan 29, 2025
SiAdcock
reviewed
Jan 29, 2025
SiAdcock
reviewed
Jan 29, 2025
Co-authored-by: Oliver Abrahams <[email protected]>
Co-authored-by: Oliver Abrahams <[email protected]>
acb38d0
to
5c488ea
Compare
Add Sticky clue and Anagram helper
SiAdcock
approved these changes
Feb 4, 2025
Seen on PROD (created by @sndrs and merged by @jamesmockett 9 minutes and 57 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Introduces crossword article layout
Why?
So we can render crossword articles in DCAR (using
@guardian/react-crossword
) instead of Frontend. This is part of the wider initiative to decommission rendering in Frontend.Screenshots