Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Word wheel storybook fix #1830

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Word wheel storybook fix #1830

merged 4 commits into from
Dec 2, 2024

Conversation

oliverabrahams
Copy link
Contributor

What are you changing?

  • Move shuffling up to Anagram helper

Why?

  • Allows storybook of word wheel to be the same and removes logic from component

@oliverabrahams oliverabrahams requested a review from a team as a code owner December 2, 2024 12:38
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f97cace

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Dec 2, 2024
@oliverabrahams oliverabrahams added the run_chromatic Runs chromatic when label is applied label Dec 2, 2024
@oliverabrahams oliverabrahams merged commit a49f7b6 into main Dec 2, 2024
23 checks passed
@oliverabrahams oliverabrahams deleted the oa/word-wheel-storybook-fix branch December 2, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sndrs sndrs sndrs approved these changes

Assignees
No one assigned
Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverabrahams @sndrs