Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tmux styles to work in tmux >= 2.9 #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nickgrim
Copy link

This PR changes the tmux defaults to work with tmux >= 2.9.

In tmux v1.9 (June 2015), specifying styles like e.g. tmux set status-left-bg green was deprecated in favour of the newer style tmux set status-left-style bg=green, and the old format was finally removed in v2.9 (March 2019).

This PR updates the defaults to actually work with tmux v2.9+. As part of this, I've updated the minimum required version of tmux to 1.9, but I feel that's ok since it's over 5 years old.

tmux deprecated setting options with e.g. `status-left-bg green` in v1.9
in favour of using `status-left-style bg=green` and removed them in
v2.9.  This migrates the `color_location` option to the new format.
@drselump14
Copy link

That's why the notifcation color never change ... wish I knew that

@nickgrim
Copy link
Author

@drselump14 (and everyone else, I guess): without this patch, you can still make colours happen by putting the following in your Guardfile:

notification :tmux, color_location: 'status-left-style', success: 'bg=green', failed: 'bg=red'

@drselump14
Copy link

drselump14 commented Nov 23, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants