This repository was archived by the owner on Jun 8, 2021. It is now read-only.
Deprecate CallbackGuard #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
1 similar comment
|
👍 |
|
Oh, it since 1.23. I fix deprecation text |
EPashkin
force-pushed
the
deprecate_CallbackGuard
branch
from
2990961 to
0e3340c
Compare
|
Updated |
sdroege
reviewed
Feb 17, 2018
src/source.rs
Outdated
| @@ -54,20 +54,24 @@ impl ToGlib for Continue { | |||
|
|
|||
| /// Unwinding propagation guard. Aborts the process if destroyed while | |||
| /// panicking. | |||
| #[deprecated(note="Rustc has this functionality buildin since 1.23.0")] | |||
|
rust-lang/rust@51b47dc contains in branches started from rust-lang/rust@d0f1f42 and rust-lang/rust@2dad872 but not in rust-lang/rust@5041b3b Strange that for me https://github.com/rust-lang/rust/releases/tag/1.23.0 not in current repo |
|
@sdroege Maybe you right, I use "Aaron Power" commits |
|
Also it's in the 1.24 release notes |
|
You right, I checked by tag archive too. I will change back |
EPashkin
force-pushed
the
deprecate_CallbackGuard
branch
from
0e3340c to
7f07bef
Compare
|
Updated |
|
Great :) |
|
All good to go now? |
|
From my side yes |
sdroege
reviewed
Feb 17, 2018
src/source.rs
Outdated
| @@ -54,20 +54,24 @@ impl ToGlib for Continue { | |||
|
|
|||
| /// Unwinding propagation guard. Aborts the process if destroyed while | |||
| /// panicking. | |||
| #[deprecated(note="Rustc has this functionality buildin since 1.24.0")] | |||
EPashkin
force-pushed
the
deprecate_CallbackGuard
branch
from
7f07bef to
ba8b1dc
Compare
|
For me PR also ready for merge |
|
Thanks then! |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #250
cc @GuillaumeGomez