fix: Remove active filter from TaskListAPI queryset#3069
Merged
Conversation
fix(task): remove active filter from TaskListAPI queryset
Contributor
Greptile SummaryThis PR expands the dashboard task list to include inactive tasks. The main change is:
|
| Filename | Overview |
|---|---|
| api/dashboard/task/dash_task_view.py | The management list now returns active and inactive tasks, but its scope no longer matches the CSV export. |
Reviews (1): Last reviewed commit: "Merge pull request #3068 from DevWithPra..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| ).annotate( | ||
| total_karma_gainers_count=Count("karma_activity_log_task", filter=Q(karma_activity_log_task__appraiser_approved=True)) | ||
| ).filter(active=True) | ||
| ) |
Contributor
There was a problem hiding this comment.
When inactive tasks exist, the dashboard list now includes them while TaskListCSV still filters on active=True. An administrator exporting the tasks shown in the dashboard receives fewer rows than the JSON list, so inactive records visible in the UI are silently omitted from the export.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.