fix(ig-requests): remove 10-character limit on icon field#329
Open
aprameyak wants to merge 1 commit into
Open
Conversation
|
@aprameyak is attempting to deploy a commit to the awindsr's projects Team on Vercel. A member of the Team first needs to authorize it. |
👷 Deploy request for staging-mulearn pending review.Visit the deploys page to approve it
|
Contributor
Greptile SummaryThis PR allows full icon URLs in the IG request form. The main changes are:
|
| Filename | Overview |
|---|---|
| src/features/ig-requests/schemas/ig-requests.schema.ts | Removes the 10-character maximum while preserving required-field validation. |
| src/features/ig-requests/components/ig-request-form-dialog.tsx | Removes the misleading emoji or short-string placeholder without changing form behavior. |
| .changeset/fix-ig-request-icon-url.md | Adds a patch release note for the icon validation fix. |
Reviews (1): Last reviewed commit: "fix(ig-requests): remove 10-character li..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the icon field on /dashboard/company/ig-requests rejecting URLs over 10 chars. Closes #328.
.max(10)on icon in CreateIGRequestFormSchema