Add book creation and list all books features#1633
Conversation
Add create_book and list_all_books features - Soorya A P
Add book app features, create and list books
Added create_book and list_all_books features - Jairaj R
Book Management Feature
Feat: Implement Create and List Book features
…eature Create create_book.txt
Introduction to Github - Mulearn task submission
Add book app features – create and list book
Add book app features – create and list books
Add book app features: create and list books
~ ~ .git/MERGE_MSG[+] [unix] (20:14 15/07/2026) 6,2 All the commit.
Greptile SummaryThis PR submits the
|
| Filename | Overview |
|---|---|
| README.md | Overwrites Saniya Manoj's name entry with Meenakshi TM's, erasing another student's submission due to a bad merge conflict resolution |
| Akash_A_book_app/add_books_feature/create_book.txt | File deleted — belongs to another student (Akash A) and should not have been removed by this PR |
| yourname_book_app/add_books_feature/create_book.txt | Uses the unrenamed template placeholder folder name instead of the author's actual name; duplicates meenakshi_tm_book_app content |
| shaheen_t_app/create_book.txt | Stray duplicate file added to another user's folder root; the correct file already exists at shaheen_t_app/add_books_feature/create_book.txt |
| meenakshi_tm_book_app/add_books_feature/create_book.txt | PR author's own create_book feature file, correctly placed and populated |
| meenakshi_tm_book_app/add_books_feature/list_all_books.txt | PR author's list_all_books feature file, correctly placed; missing newline at end of file |
| Athira_create_book.txt | Empty file placed at repo root rather than inside a properly named book_app/add_books_feature/ directory |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[PR Author: Meenakshitm2005] --> B{Files submitted}
B --> C[✅ meenakshi_tm_book_app/\nadd_books_feature/create_book.txt]
B --> D[✅ meenakshi_tm_book_app/\nadd_books_feature/list_all_books.txt]
B --> E[⚠️ yourname_book_app/\nadd_books_feature/create_book.txt\n— placeholder name]
B --> F[⚠️ yourname_book_app/\nadd_books_feature/list_all_books.txt\n— placeholder name]
B --> G[❌ README.md\n— overwrites Saniya Manoj's entry]
B --> H[❌ Akash_A_book_app + akash_a_book_app\ncreate_book.txt deleted]
B --> I[❌ shaheen_t_app/create_book.txt\n— stray file in another user's folder]
B --> J[⚠️ Athira_create_book.txt\n— empty file at repo root]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[PR Author: Meenakshitm2005] --> B{Files submitted}
B --> C[✅ meenakshi_tm_book_app/\nadd_books_feature/create_book.txt]
B --> D[✅ meenakshi_tm_book_app/\nadd_books_feature/list_all_books.txt]
B --> E[⚠️ yourname_book_app/\nadd_books_feature/create_book.txt\n— placeholder name]
B --> F[⚠️ yourname_book_app/\nadd_books_feature/list_all_books.txt\n— placeholder name]
B --> G[❌ README.md\n— overwrites Saniya Manoj's entry]
B --> H[❌ Akash_A_book_app + akash_a_book_app\ncreate_book.txt deleted]
B --> I[❌ shaheen_t_app/create_book.txt\n— stray file in another user's folder]
B --> J[⚠️ Athira_create_book.txt\n— empty file at repo root]
Comments Outside Diff (1)
-
Akash_A_book_app/add_books_feature/create_book.txtThis PR deletes both
Akash_A_book_app/add_books_feature/create_book.txtandakash_a_book_app/add_books_feature/create_book.txt, which belong to a different student (Akash A). These files are not the PR author's work and their removal will erase another participant's task submission. They should be restored.
Reviews (1): Last reviewed commit: "Merge branch 'feature' into develop" | Re-trigger Greptile
| - Name: Meenakshi TM | ||
| - Task: Completed GitHub Basics |
There was a problem hiding this comment.
Another student's README entry overwritten
The README previously contained - Name: Saniya Manoj and this PR replaces it with - Name: Meenakshi TM. This appears to be a merge conflict that was incorrectly resolved by keeping only the PR author's entry. Saniya Manoj's submission has been erased from the file. The correct resolution is to append a new entry rather than overwrite the previous one.
| @@ -0,0 +1 @@ | |||
| This is the feature for the author to add a new book. | |||
There was a problem hiding this comment.
Placeholder folder name submitted
The folder yourname_book_app is the template placeholder from the task instructions and should have been renamed to the actual contributor's name (e.g., meenakshi_tm_book_app). A properly named folder (meenakshi_tm_book_app) already exists in this PR, so these files in yourname_book_app are redundant duplicates under the wrong name.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| @@ -0,0 +1 @@ | |||
| This is the feature for the author to add a new book. | |||
There was a problem hiding this comment.
Duplicate file placed in wrong location within another user's folder
shaheen_t_app/create_book.txt is a duplicate of shaheen_t_app/add_books_feature/create_book.txt and is placed at the root of another user's (shaheen_t) folder rather than inside the add_books_feature/ subdirectory. The PR author should not be adding files to other participants' folders, and this stray file should be removed.
| @@ -0,0 +1 @@ | |||
|
|
|||
There was a problem hiding this comment.
Empty file placed at repo root instead of proper folder structure
Athira_create_book.txt is placed at the repository root and contains only a blank line. The expected structure is <name>_book_app/add_books_feature/create_book.txt. This file does not follow the task conventions and is empty, so it should either be removed or placed in the correct directory with the required content.
Changes Made
This PR completes the Git & GitHub workflow task for GTech µLearn.