Skip to content

Add book creation and list all books features#1633

Open
Meenakshitm2005 wants to merge 111 commits into
gtech-mulearn:developfrom
Meenakshitm2005:develop
Open

Add book creation and list all books features#1633
Meenakshitm2005 wants to merge 111 commits into
gtech-mulearn:developfrom
Meenakshitm2005:develop

Conversation

@Meenakshitm2005

Copy link
Copy Markdown

Changes Made

  • Added the create_book feature.
  • Added the list_all_books feature.
  • Enhanced list_all_books to display books in ascending order.
  • Merged the feature branch into develop.

This PR completes the Git & GitHub workflow task for GTech µLearn.

Athira1903 and others added 30 commits April 2, 2025 14:49
Add create_book and list_all_books features - Soorya A P
Add book app features, create and list books
Added create_book and list_all_books features - Jairaj R
milansijo and others added 28 commits December 15, 2025 19:36
Feat: Implement Create and List Book features
Introduction to Github - Mulearn task submission
Add book app features – create and list book
Add book app features – create and list books
Add book app features: create and list books
                                                                              ~                                                                               ~                                                                               .git/MERGE_MSG[+] [unix] (20:14 15/07/2026)                              6,2 All

 the commit.
@greptile-apps

greptile-apps Bot commented Jul 15, 2026

Copy link
Copy Markdown

Greptile Summary

This PR submits the create_book and list_all_books feature files for meenakshi_tm_book_app, but it also introduces several problematic changes that affect other participants' work.

  • The author's own files (meenakshi_tm_book_app/add_books_feature/) are correctly structured and populated, completing the intended task.
  • README.md has a bad merge-conflict resolution that silently replaces another student's entry (Saniya Manoj) with the PR author's name instead of appending a new line.
  • Two files belonging to another student (Akash_A_book_app and akash_a_book_app) are deleted, and a stray create_book.txt is added inside shaheen_t_app/ (another user's folder). A yourname_book_app placeholder folder with the un-renamed template name is also included.

Confidence Score: 2/5

Not safe to merge — multiple other students' files are deleted or overwritten by this PR.

The PR deletes two files belonging to another student (Akash A), replaces a different student's (Saniya Manoj) README entry rather than appending to it, adds a file inside yet another student's folder (shaheen_t_app), and submits work under the unrenamed template folder name (yourname_book_app). The author's intended files in meenakshi_tm_book_app are correct, but the collateral damage to other participants' submissions makes this unsafe to merge without fixes.

README.md (overwritten entry), Akash_A_book_app/add_books_feature/create_book.txt and akash_a_book_app/add_books_feature/create_book.txt (deleted), shaheen_t_app/create_book.txt (stray file), yourname_book_app/ (placeholder name)

Important Files Changed

Filename Overview
README.md Overwrites Saniya Manoj's name entry with Meenakshi TM's, erasing another student's submission due to a bad merge conflict resolution
Akash_A_book_app/add_books_feature/create_book.txt File deleted — belongs to another student (Akash A) and should not have been removed by this PR
yourname_book_app/add_books_feature/create_book.txt Uses the unrenamed template placeholder folder name instead of the author's actual name; duplicates meenakshi_tm_book_app content
shaheen_t_app/create_book.txt Stray duplicate file added to another user's folder root; the correct file already exists at shaheen_t_app/add_books_feature/create_book.txt
meenakshi_tm_book_app/add_books_feature/create_book.txt PR author's own create_book feature file, correctly placed and populated
meenakshi_tm_book_app/add_books_feature/list_all_books.txt PR author's list_all_books feature file, correctly placed; missing newline at end of file
Athira_create_book.txt Empty file placed at repo root rather than inside a properly named book_app/add_books_feature/ directory

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR Author: Meenakshitm2005] --> B{Files submitted}
    B --> C[✅ meenakshi_tm_book_app/\nadd_books_feature/create_book.txt]
    B --> D[✅ meenakshi_tm_book_app/\nadd_books_feature/list_all_books.txt]
    B --> E[⚠️ yourname_book_app/\nadd_books_feature/create_book.txt\n— placeholder name]
    B --> F[⚠️ yourname_book_app/\nadd_books_feature/list_all_books.txt\n— placeholder name]
    B --> G[❌ README.md\n— overwrites Saniya Manoj's entry]
    B --> H[❌ Akash_A_book_app + akash_a_book_app\ncreate_book.txt deleted]
    B --> I[❌ shaheen_t_app/create_book.txt\n— stray file in another user's folder]
    B --> J[⚠️ Athira_create_book.txt\n— empty file at repo root]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[PR Author: Meenakshitm2005] --> B{Files submitted}
    B --> C[✅ meenakshi_tm_book_app/\nadd_books_feature/create_book.txt]
    B --> D[✅ meenakshi_tm_book_app/\nadd_books_feature/list_all_books.txt]
    B --> E[⚠️ yourname_book_app/\nadd_books_feature/create_book.txt\n— placeholder name]
    B --> F[⚠️ yourname_book_app/\nadd_books_feature/list_all_books.txt\n— placeholder name]
    B --> G[❌ README.md\n— overwrites Saniya Manoj's entry]
    B --> H[❌ Akash_A_book_app + akash_a_book_app\ncreate_book.txt deleted]
    B --> I[❌ shaheen_t_app/create_book.txt\n— stray file in another user's folder]
    B --> J[⚠️ Athira_create_book.txt\n— empty file at repo root]
Loading

Comments Outside Diff (1)

  1. Akash_A_book_app/add_books_feature/create_book.txt

    P1 Other students' files deleted

    This PR deletes both Akash_A_book_app/add_books_feature/create_book.txt and akash_a_book_app/add_books_feature/create_book.txt, which belong to a different student (Akash A). These files are not the PR author's work and their removal will erase another participant's task submission. They should be restored.

Reviews (1): Last reviewed commit: "Merge branch 'feature' into develop" | Re-trigger Greptile

Comment thread README.md
Comment on lines +130 to 131
- Name: Meenakshi TM
- Task: Completed GitHub Basics

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Another student's README entry overwritten

The README previously contained - Name: Saniya Manoj and this PR replaces it with - Name: Meenakshi TM. This appears to be a merge conflict that was incorrectly resolved by keeping only the PR author's entry. Saniya Manoj's submission has been erased from the file. The correct resolution is to append a new entry rather than overwrite the previous one.

@@ -0,0 +1 @@
This is the feature for the author to add a new book.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Placeholder folder name submitted

The folder yourname_book_app is the template placeholder from the task instructions and should have been renamed to the actual contributor's name (e.g., meenakshi_tm_book_app). A properly named folder (meenakshi_tm_book_app) already exists in this PR, so these files in yourname_book_app are redundant duplicates under the wrong name.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@@ -0,0 +1 @@
This is the feature for the author to add a new book.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Duplicate file placed in wrong location within another user's folder

shaheen_t_app/create_book.txt is a duplicate of shaheen_t_app/add_books_feature/create_book.txt and is placed at the root of another user's (shaheen_t) folder rather than inside the add_books_feature/ subdirectory. The PR author should not be adding files to other participants' folders, and this stray file should be removed.

Comment thread Athira_create_book.txt
@@ -0,0 +1 @@

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Empty file placed at repo root instead of proper folder structure

Athira_create_book.txt is placed at the repository root and contains only a blank line. The expected structure is <name>_book_app/add_books_feature/create_book.txt. This file does not follow the task conventions and is empty, so it should either be removed or placed in the correct directory with the required content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.