Feat: Implement Book Management Folders and Features for P Sajai KrishnaDevelop#1617
Feat: Implement Book Management Folders and Features for P Sajai KrishnaDevelop#1617Sajai-afk wants to merge 2 commits into
Conversation
Greptile SummaryThis PR completes a Git workflow assignment by adding two plain-text feature description files under a personal project directory (
Both files are saved in UTF-16 LE with BOM encoding, which causes git to treat them as binary. For plain text files this prevents
|
| Filename | Overview |
|---|---|
| p_sajai_krishna_book_app/add_books_feature/create_book.txt | New text file describing the 'add a new book' feature; saved in UTF-16 LE with BOM, causing git to classify it as binary. |
| p_sajai_krishna_book_app/add_books_feature/list_all_books.txt | New text file describing the 'list all books' feature; also saved in UTF-16 LE with BOM, causing git to classify it as binary. |
Sequence Diagram
%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
participant Dev as Developer (develop branch)
participant Feat as feature branch
participant Main as main branch
Dev->>Dev: Create create_book.txt (commit)
Dev->>Dev: "Stage & unstage list_all_books.txt (practice)"
Dev->>Feat: Create feature branch
Feat->>Feat: Add list_all_books.txt (ascending order logic, 2 commits)
Feat->>Dev: Merge feature into develop
Dev->>Main: Open PR to main
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
participant Dev as Developer (develop branch)
participant Feat as feature branch
participant Main as main branch
Dev->>Dev: Create create_book.txt (commit)
Dev->>Dev: "Stage & unstage list_all_books.txt (practice)"
Dev->>Feat: Create feature branch
Feat->>Feat: Add list_all_books.txt (ascending order logic, 2 commits)
Feat->>Dev: Merge feature into develop
Dev->>Main: Open PR to main
Comments Outside Diff (1)
-
p_sajai_krishna_book_app/add_books_feature/create_book.txt, line 1 (link)Files saved as UTF-16, detected as binary by git
Both
create_book.txtandlist_all_books.txtare encoded as UTF-16 LE with a BOM (\xFF\xFE), which causes git to classify them as binary files. This meansgit diffcannot show line-by-line textual differences — the whole point of storing text in a version-control system. Plain.txtfeature-description files like these should be saved in UTF-8 (without BOM). Please re-save both files as UTF-8 and recommit.
Reviews (1): Last reviewed commit: "Feat: Add create book feature text file" | Re-trigger Greptile
What was done in this PR:
p_sajai_krishna_book_appand nested theadd_books_featureworkspace inside it.create_book.txtfeature on thedevelopbranch and committed it.list_all_books.txtfile.featurebranch to finish the book listing feature, adding logic for ascending order across two separate commits.featurebranch back into thedevelopbranch to complete the workflow.This completes the entire basic Git & GitHub workflow assignment!