Added add books feature - #1613
Conversation
Add create_book and list_all_books features - Soorya A P
Add book app features, create and list books
Added create_book and list_all_books features - Jairaj R
Book Management Feature
Implemented Book Features with proper Git Workflow
Added Book App Features (Create Book & List Books)
Github_Enablement_Task
Github_Enablement_Task
Added book features (create & list books)
- Created add_books_feature directory - Added create_book.txt with feature description Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Shows all books created by the user as a list Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Books will be listed in ascending order - Improves book discovery for users Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Includes list_all_books feature with sorting capability - Combines with create_book feature from develop Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add book app with create and list features - Mithun Thomas
Greptile SummaryThis PR adds
|
| Filename | Overview |
|---|---|
| my_intro.txt | Another contributor's intro (ChrisNijo) was overwritten with Pranav's intro — must be reverted. |
| yourname_book_app/add_books_feature/create_book.txt | Template placeholder directory committed; "yourname" was never replaced with the actual contributor name. |
| Athira_create_book.txt | Empty file placed at repo root instead of inside a personal app directory's add_books_feature subfolder. |
| aswika_grifith_book_app/add_books_feature/aswika_grifith_book_app/add_books_feature/list_all_books.txt | Duplicate nested path — full app path repeated inside itself, creating a redundant deep directory. |
| jesty_book_app/add_book_feature/create_book.txt | Folder named add_book_feature (missing 's') instead of the required add_books_feature. |
| Muhammad_Nasih_book_app/create_book.txt | Files placed at app root instead of inside the add_books_feature subdirectory; same issue in milan_sijo_book_app and shaheen_t_app. |
| list_all_books.txt | Root-level shared file had a duplicate line appended; file should not be at the repo root. |
| keziah_mariam_raison_book_app/add_books_feature/create_book.txt | Correctly placed create_book.txt inside the add_books_feature subdirectory — representative of the well-structured contributions. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Contributor submits PR] --> B{Files in correct location?}
B -- Yes --> C[personal_name_book_app/add_books_feature/create_book.txt ✅]
B -- Yes --> D[personal_name_book_app/add_books_feature/list_all_books.txt ✅]
B -- No --> E{What went wrong?}
E --> F[my_intro.txt overwritten ❌
Another contributor's file modified]
E --> G[yourname_book_app/ committed ❌
Template placeholder not replaced]
E --> H[Athira_create_book.txt at root ❌
Empty file, wrong location]
E --> I[Muhammad_Nasih / milan_sijo / shaheen_t ❌
Files not inside add_books_feature/]
E --> J[jesty_book_app/add_book_feature/ ❌
Folder name missing 's']
E --> K[aswika_grifith nested path ❌
Full path repeated inside itself]
E --> L[list_all_books.txt at root ❌
Duplicate line appended to shared file]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[Contributor submits PR] --> B{Files in correct location?}
B -- Yes --> C[personal_name_book_app/add_books_feature/create_book.txt ✅]
B -- Yes --> D[personal_name_book_app/add_books_feature/list_all_books.txt ✅]
B -- No --> E{What went wrong?}
E --> F[my_intro.txt overwritten ❌
Another contributor's file modified]
E --> G[yourname_book_app/ committed ❌
Template placeholder not replaced]
E --> H[Athira_create_book.txt at root ❌
Empty file, wrong location]
E --> I[Muhammad_Nasih / milan_sijo / shaheen_t ❌
Files not inside add_books_feature/]
E --> J[jesty_book_app/add_book_feature/ ❌
Folder name missing 's']
E --> K[aswika_grifith nested path ❌
Full path repeated inside itself]
E --> L[list_all_books.txt at root ❌
Duplicate line appended to shared file]
Reviews (1): Last reviewed commit: "Added add books feature" | Re-trigger Greptile
| @@ -1 +1 @@ | |||
| Hello from ChrisNijo | |||
| Hey there it's Pranav here aka Alien | |||
There was a problem hiding this comment.
Unauthorized modification of another contributor's file
my_intro.txt originally contained Hello from ChrisNijo and this PR replaces it with Hey there it's Pranav here aka Alien. This file belongs to a different contributor and must not be overwritten by this PR. The original content should be restored.
| @@ -1,2 +1,3 @@ | |||
| This is the feature which shows the user all the books they’ve created as a list. | |||
| List all books will list all books in ascending order. | |||
| List all books will list all books in ascending order. | |||
There was a problem hiding this comment.
Duplicate line appended to a shared root-level file
The line List all books will list all books in ascending order. already existed on line 2 and is now duplicated here. Additionally, this file appears to be a shared/root-level artifact rather than being placed inside a personal <name>_book_app/add_books_feature/ directory as required by the task structure.
| @@ -0,0 +1 @@ | |||
| List all books will list all books in ascending order. | |||
There was a problem hiding this comment.
This file was committed at aswika_grifith_book_app/add_books_feature/aswika_grifith_book_app/add_books_feature/list_all_books.txt — the full app path is repeated inside itself. The correct location is aswika_grifith_book_app/add_books_feature/list_all_books.txt, which also exists in this PR. The nested copy is redundant and incorrectly placed.
| @@ -0,0 +1 @@ | |||
| This feature allows the author to create a new book. | |||
There was a problem hiding this comment.
Incorrect folder name:
add_book_feature instead of add_books_feature
The directory is named add_book_feature (missing the s), while every other contributor uses add_books_feature. This deviates from the expected task structure and will fail any automated checks that rely on the folder name. The files should be moved to jesty_book_app/add_books_feature/.
| @@ -0,0 +1 @@ | |||
| This is the feature for the author to add a new book. | |||
There was a problem hiding this comment.
Files not placed inside the required
add_books_feature subdirectory
create_book.txt and list_all_books.txt for Muhammad_Nasih are placed directly under Muhammad_Nasih_book_app/ instead of Muhammad_Nasih_book_app/add_books_feature/. The same issue exists for milan_sijo_book_app/ and shaheen_t_app/ (which has an extra stray create_book.txt at the app root in addition to the correctly placed copy in add_books_feature/).
| @@ -0,0 +1 @@ | |||
|
|
|||
There was a problem hiding this comment.
File placed at repository root instead of a personal app directory
Athira_create_book.txt is committed at the root of the repo and its content is empty. It should instead be placed at athira_book_app/add_books_feature/create_book.txt (or a similar personal directory) with appropriate content, matching the pattern used by every other contributor.
| @@ -0,0 +1 @@ | |||
| This is the feature for the author to add a new book. | |||
There was a problem hiding this comment.
Placeholder
yourname_book_app directory committed
yourname_book_app/ is a template placeholder and should never appear in the repository. The submitter should have replaced "yourname" with their actual name. Both files inside this directory should be removed and re-submitted under the correct personal directory.
Added create_book.txt and list_all_books.txt inside add_books_feature directory for the book app task.