Skip to content

Added add books feature - #1613

Open
mrfighterz wants to merge 176 commits into
gtech-mulearn:developfrom
mrfighterz:add_books_feature
Open

Added add books feature#1613
mrfighterz wants to merge 176 commits into
gtech-mulearn:developfrom
mrfighterz:add_books_feature

Conversation

@mrfighterz

Copy link
Copy Markdown

Added create_book.txt and list_all_books.txt inside add_books_feature directory for the book app task.

Athira1903 and others added 30 commits April 2, 2025 14:49
Add create_book and list_all_books features - Soorya A P
Add book app features, create and list books
Added create_book and list_all_books features - Jairaj R
Lexlonnn and others added 28 commits March 3, 2026 17:52
OMerge branch 'feature' into develop
Implemented Book Features with proper Git Workflow
Added Book App Features (Create Book & List Books)
Added book features (create & list books)
- Created add_books_feature directory
- Added create_book.txt with feature description

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Shows all books created by the user as a list

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Books will be listed in ascending order
- Improves book discovery for users

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Includes list_all_books feature with sorting capability
- Combines with create_book feature from develop

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add book app with create and list features - Mithun Thomas
@greptile-apps

greptile-apps Bot commented Jun 23, 2026

Copy link
Copy Markdown

Greptile Summary

This PR adds create_book.txt and list_all_books.txt task files for many contributors, but bundles together submissions from multiple people alongside several structural mistakes and one critical cross-contributor file corruption.

  • my_intro.txt — owned by contributor ChrisNijo — has its contents replaced with Pranav's introduction, directly overwriting another person's work.
  • Multiple contributors placed their files at the wrong path: yourname_book_app/ (a template placeholder that was never renamed), Athira_create_book.txt at the repo root (empty), Muhammad_Nasih_book_app/, milan_sijo_book_app/, and shaheen_t_app/ all put files directly at the app root instead of inside add_books_feature/; jesty_book_app/ uses the typo directory add_book_feature; and aswika_grifith_book_app repeated its own path inside itself, creating an erroneous nested directory.

Confidence Score: 1/5

Not safe to merge — another contributor's file is directly overwritten, placeholder directories are committed, and multiple files land in the wrong paths.

The most serious change is the replacement of ChrisNijo's content in my_intro.txt with a different contributor's introduction, which destroys existing work. On top of that, yourname_book_app/ (an unfilled template) is committed, Athira_create_book.txt is an empty file at the repo root, several contributors placed their files outside the required add_books_feature/ subdirectory, jesty_book_app uses a misspelled folder name, and aswika_grifith_book_app has a deeply nested duplicate path. The volume and variety of structural errors across this single PR make it risky to merge without a thorough cleanup pass.

my_intro.txt (overwritten content), yourname_book_app/ (template placeholder), Athira_create_book.txt (empty, wrong location), Muhammad_Nasih_book_app/create_book.txt, milan_sijo_book_app/create_book.txt, shaheen_t_app/create_book.txt (wrong directory level), jesty_book_app/add_book_feature/ (typo in folder name), aswika_grifith_book_app nested duplicate path, and list_all_books.txt at repo root.

Important Files Changed

Filename Overview
my_intro.txt Another contributor's intro (ChrisNijo) was overwritten with Pranav's intro — must be reverted.
yourname_book_app/add_books_feature/create_book.txt Template placeholder directory committed; "yourname" was never replaced with the actual contributor name.
Athira_create_book.txt Empty file placed at repo root instead of inside a personal app directory's add_books_feature subfolder.
aswika_grifith_book_app/add_books_feature/aswika_grifith_book_app/add_books_feature/list_all_books.txt Duplicate nested path — full app path repeated inside itself, creating a redundant deep directory.
jesty_book_app/add_book_feature/create_book.txt Folder named add_book_feature (missing 's') instead of the required add_books_feature.
Muhammad_Nasih_book_app/create_book.txt Files placed at app root instead of inside the add_books_feature subdirectory; same issue in milan_sijo_book_app and shaheen_t_app.
list_all_books.txt Root-level shared file had a duplicate line appended; file should not be at the repo root.
keziah_mariam_raison_book_app/add_books_feature/create_book.txt Correctly placed create_book.txt inside the add_books_feature subdirectory — representative of the well-structured contributions.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Contributor submits PR] --> B{Files in correct location?}
    B -- Yes --> C[personal_name_book_app/add_books_feature/create_book.txt ✅]
    B -- Yes --> D[personal_name_book_app/add_books_feature/list_all_books.txt ✅]
    B -- No --> E{What went wrong?}
    E --> F[my_intro.txt overwritten ❌
Another contributor's file modified]
    E --> G[yourname_book_app/ committed ❌
Template placeholder not replaced]
    E --> H[Athira_create_book.txt at root ❌
Empty file, wrong location]
    E --> I[Muhammad_Nasih / milan_sijo / shaheen_t ❌
Files not inside add_books_feature/]
    E --> J[jesty_book_app/add_book_feature/ ❌
Folder name missing 's']
    E --> K[aswika_grifith nested path ❌
Full path repeated inside itself]
    E --> L[list_all_books.txt at root ❌
Duplicate line appended to shared file]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[Contributor submits PR] --> B{Files in correct location?}
    B -- Yes --> C[personal_name_book_app/add_books_feature/create_book.txt ✅]
    B -- Yes --> D[personal_name_book_app/add_books_feature/list_all_books.txt ✅]
    B -- No --> E{What went wrong?}
    E --> F[my_intro.txt overwritten ❌
Another contributor's file modified]
    E --> G[yourname_book_app/ committed ❌
Template placeholder not replaced]
    E --> H[Athira_create_book.txt at root ❌
Empty file, wrong location]
    E --> I[Muhammad_Nasih / milan_sijo / shaheen_t ❌
Files not inside add_books_feature/]
    E --> J[jesty_book_app/add_book_feature/ ❌
Folder name missing 's']
    E --> K[aswika_grifith nested path ❌
Full path repeated inside itself]
    E --> L[list_all_books.txt at root ❌
Duplicate line appended to shared file]
Loading

Reviews (1): Last reviewed commit: "Added add books feature" | Re-trigger Greptile

Comment thread my_intro.txt
@@ -1 +1 @@
Hello from ChrisNijo
Hey there it's Pranav here aka Alien

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Unauthorized modification of another contributor's file

my_intro.txt originally contained Hello from ChrisNijo and this PR replaces it with Hey there it's Pranav here aka Alien. This file belongs to a different contributor and must not be overwritten by this PR. The original content should be restored.

Comment thread list_all_books.txt
@@ -1,2 +1,3 @@
This is the feature which shows the user all the books they’ve created as a list.
List all books will list all books in ascending order.
List all books will list all books in ascending order.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Duplicate line appended to a shared root-level file

The line List all books will list all books in ascending order. already existed on line 2 and is now duplicated here. Additionally, this file appears to be a shared/root-level artifact rather than being placed inside a personal <name>_book_app/add_books_feature/ directory as required by the task structure.

@@ -0,0 +1 @@
List all books will list all books in ascending order.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Deeply nested duplicate path

This file was committed at aswika_grifith_book_app/add_books_feature/aswika_grifith_book_app/add_books_feature/list_all_books.txt — the full app path is repeated inside itself. The correct location is aswika_grifith_book_app/add_books_feature/list_all_books.txt, which also exists in this PR. The nested copy is redundant and incorrectly placed.

@@ -0,0 +1 @@
This feature allows the author to create a new book.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Incorrect folder name: add_book_feature instead of add_books_feature

The directory is named add_book_feature (missing the s), while every other contributor uses add_books_feature. This deviates from the expected task structure and will fail any automated checks that rely on the folder name. The files should be moved to jesty_book_app/add_books_feature/.

@@ -0,0 +1 @@
This is the feature for the author to add a new book.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Files not placed inside the required add_books_feature subdirectory

create_book.txt and list_all_books.txt for Muhammad_Nasih are placed directly under Muhammad_Nasih_book_app/ instead of Muhammad_Nasih_book_app/add_books_feature/. The same issue exists for milan_sijo_book_app/ and shaheen_t_app/ (which has an extra stray create_book.txt at the app root in addition to the correctly placed copy in add_books_feature/).

Comment thread Athira_create_book.txt
@@ -0,0 +1 @@

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 File placed at repository root instead of a personal app directory

Athira_create_book.txt is committed at the root of the repo and its content is empty. It should instead be placed at athira_book_app/add_books_feature/create_book.txt (or a similar personal directory) with appropriate content, matching the pattern used by every other contributor.

@@ -0,0 +1 @@
This is the feature for the author to add a new book.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Placeholder yourname_book_app directory committed

yourname_book_app/ is a template placeholder and should never appear in the repository. The submitter should have replaced "yourname" with their actual name. Both files inside this directory should be removed and re-submitted under the correct personal directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.