Ok so I finally got Viveks code to compile by doing the 2 following t…#47
Open
DogeDevYT wants to merge 5 commits into
Open
Ok so I finally got Viveks code to compile by doing the 2 following t…#47DogeDevYT wants to merge 5 commits into
DogeDevYT wants to merge 5 commits into
Conversation
…hings: 1. Modifying the ast.rs code to check close to 0 to account for angles close to 360 degrees, therefore 0 2. changing the eval_step() function at line 429 to return a UnitLiteral or a singular QubitRef when the items in our vals vector is 0 or 1 respectively I also split up the unit tests to be by purpose for the poster as well so it would be easier to test if something breaks.
ausbin
reviewed
Jun 8, 2026
ausbin
left a comment
ausbin
left a comment
Member
There was a problem hiding this comment.
In addition to my comments/questions, can you please run cargo fmt inside qwerty_ast/? If you are inside qwerty_pyrt, you can do this conveniently with pushd ../qwerty_ast; cafgo fmt; popd
Member
There was a problem hiding this comment.
What you did here is much better unit testing than what I was originally doing, thanks for that
gt-tinker#46) * So I think I got the docs edited right lowkenuinely * ok this should fix the weird permission issue + get the formatting right on docs/testing.md * remove .gitattributes * fix qir_runner submodule staging + edit testign docs * Sync qir_runner with upstream main
Get this to be most updated changes on repo for future updates
Contributor
Author
|
I think that new stuff from submodules is just what akshay added with his MLIR lowering code but lmk if I'm mistaken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hings:
I also split up the unit tests to be by purpose for the poster as well so it would be easier to test if something breaks.