Accessibility Pass - Primary Updates #205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emantic. _callout.dart also has Focus set. This allows the user to select all the text in the wonders_details_screens.
…gnorePointerWithSchematics.
… not both labelled as "next".
…tarts on English).
…ver from highlighting them unnecessarily.
AlexGarneau
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include:
Swapped Current / Total count for carousel indicators
Fixed order of selectable content in wonder_details by adding focus to non-capitalized paragraphs - screen readers were originally skipping over anything without a massive capital letter
Added Focus to Artifact Details so screen readers can read them
Swapped out deprecated IgnorePointer code
Renamed "previous" button from "next" to "previous" (no idea how that happened)
Added lang="en" to HTML tag
Gave search input a max width so it doesn't expand too far left on a full screen view (for people with limited field of vision)
Removed semantics for illustration images so the screen reader won't highlight them
And more to come!