Accessibility Pass - Subtask - Animation Times and Reduced Motion mode #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….times. Adjusted collectable icon so it doesn't flash like crazy in reduced motion mode. Still trying to figure out how to remove the animation when the user returned from the editorials to the wonder illustrations view.
…erive from styles.
AlexGarneau
changed the title
esDotDev
requested changes
Mar 6, 2025
| fit: BoxFit.contain, | ||
| ), | ||
| ) | ||
| .animate(onPlay: (controller) => controller.repeat()) |
There was a problem hiding this comment.
This should be using the default animation time that is set in app_scaffold, so it should already be shortened?
lib/styles/styles.dart
Outdated
| late final Duration delayMed = Duration(milliseconds: disabled ? 0 : 500); | ||
| late final Duration delaySlow = Duration(milliseconds: disabled ? 0 : 700); | ||
| late final Duration delayXSlow = Duration(milliseconds: disabled ? 0 : 1050); | ||
| late final Duration delayXXSlow = Duration(milliseconds: disabled ? 0 : 4000); |
There was a problem hiding this comment.
I don't really want to add a ton of extra fields here... I think for most of these we will want to keep them as "non standard" values inside the view and we'll just support low-motion directly in that view. But I don't want to add a ton of boilerplate either. I'll have to think on this for a bit...
…d instead allow everything to pass in their custom MS and retrieve the duration or delay, which is affected by disableAnimations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate branch for setting up reduced motion mode by moving all animation-based times into styles.times and setting their duration to 1.
Currently forcing this true for debug purposes - will switch it out after completion.