[#140] Removed deprecated variable openshift_node_kubelet_args #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
last_checked_var: openshift_master_identity_providers;Found removed variables: openshift_node_kubelet_args is replaced by openshift_node_groups[<item>].edits; Since the install fails ont he above and the inventory.ini file is downloaded every time fromt eh configured repo I had to fork and commit this. without the node_groups, it will all back to the default.
Replaced variable removed
…ariable [gshipley#140] oc command not found with OKD 3.10+
|
Looks good to me, just needs to be squashed in one commit |
|
can I do that from the webinterface or do i need to pull and recommit with -ff ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix as per work around #140 (comment)
openshift_node_kubelet_args inventory variable was deprecated in 3.10 and removed in 3.11.
This causes the ansible install to fail.
Also confirmed in Openshift-Ansible : openshift/openshift-ansible#11069 (comment)
This means the configuration this is no longer as intended, so this is not a real fix, HOWEVER, the default value for pods per core has been 10 since 3.3.
https://docs.openshift.com/container-platform/3.11/admin_guide/manage_nodes.html#admin-guide-max-pods-per-node
If needed the value can be adjusted in /etc/origin/node/node-config.yaml