Skip to content

feat: Update OAuth scopes to request 'name' instead of 'profile'.#446

Merged
akrnwl merged 1 commit into
gsainfoteam:developmentfrom
akrnwl:eomoonkyung/pga-233
Mar 20, 2026
Merged

feat: Update OAuth scopes to request 'name' instead of 'profile'.#446
akrnwl merged 1 commit into
gsainfoteam:developmentfrom
akrnwl:eomoonkyung/pga-233

Conversation

@akrnwl

@akrnwl akrnwl commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

scope를 profile -> name으로 바꾸었습니다.

Summary by CodeRabbit

릴리스 노트

  • Refactor
    • OAuth 인증 요청에서 요청하는 권한(scope)을 업데이트했습니다. 사용자 정보 수집 방식이 개선되었습니다.

@coderabbitai

coderabbitai Bot commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 86320d7f-bf2a-42f6-bcf3-303edd2d20e0

📥 Commits

Reviewing files that changed from the base of the PR and between 74edb6c and 886b913.

📒 Files selected for processing (1)
  • lib/app/modules/auth/data/repositories/web_auth_2_oauth_repository.dart

📝 Walkthrough

Walkthrough

OAuth 인증 요청의 scope 매개변수가 업데이트되었습니다. _getResult 메서드에서 ['profile', 'email', 'offline_access']에서 ['name', 'email', 'offline_access']로 변경되었으며, 다른 제어 흐름이나 동작은 변경되지 않았습니다.

Changes

Cohort / File(s) Summary
OAuth Scope 업데이트
lib/app/modules/auth/data/repositories/web_auth_2_oauth_repository.dart
OAuth 인증 요청의 scope 매개변수에서 'profile'을 'name'으로 변경하여 요청 권한 범위를 조정했습니다.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 작은 변화 속에 큰 의미, 프로필에서 이름으로,
인증의 영역을 다시 그으며,
scope는 깊어지고 코드는 더욱 정교해져,
한 줄의 마법으로 모든 것이 다시 시작되네! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목이 변경 사항의 주요 내용을 명확하게 요약하고 있습니다. OAuth 스코프를 'profile'에서 'name'으로 변경했다는 내용이 정확하게 반영되어 있습니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can customize the tone of the review comments and chat replies.

Configure the tone_instructions setting to customize the tone of the review comments and chat replies. For example, you can set the tone to Act like a strict teacher, Act like a pirate and more.

@akrnwl

akrnwl commented Mar 20, 2026

Copy link
Copy Markdown
Contributor Author

찾아보니 따로 scopes에 추가 안하면 optional로 된다고 하더라구요. 그래서 괜찮을 것 같습니다.

@akrnwl
akrnwl enabled auto-merge (squash) March 20, 2026 13:53
@akrnwl
akrnwl merged commit a92f9c0 into gsainfoteam:development Mar 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants