fix: add age assurance to fastfile#438
Conversation
📝 WalkthroughWalkthroughApp Store 제출 구성을 확장하기 위해 iOS Fastlane Fastfile의 production lane 내 deliver(...) 호출에 Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ios/fastlane/Fastfile (1)
82-95:⚠️ Potential issue | 🔴 Critical
deliver에서age_assurance옵션을 잘못 사용했습니다Fastlane 2.229에서는
age_assurance: 'none'이 유효한 옵션이 아닙니다. 나이 보증 설정은app_rating_config_path를 통해 JSON 파일로 전달되어야 하며, JSON 내에서ageAssurance(카멜케이스)를 boolean 값(true/false)으로 설정해야 합니다. 현재 코드는 런타임 시 옵션 검증에서 실패합니다.올바른 구현 방식
# fastlane/age_rating.json 파일 생성 { "ageAssurance": false } # deliver 호출 deliver( app_rating_config_path: "fastlane/age_rating.json", # ... 다른 옵션들 )🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ios/fastlane/Fastfile` around lines 82 - 95, The Fastfile is passing an invalid deliver option age_assurance; remove the age_assurance: 'none' entry and instead create a JSON file (e.g., fastlane/age_rating.json) containing the camelCase boolean field "ageAssurance": false, then call deliver with app_rating_config_path: "fastlane/age_rating.json" (keep other deliver options unchanged) so deliver reads the age assurance from that JSON.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@ios/fastlane/Fastfile`:
- Around line 82-95: The Fastfile is passing an invalid deliver option
age_assurance; remove the age_assurance: 'none' entry and instead create a JSON
file (e.g., fastlane/age_rating.json) containing the camelCase boolean field
"ageAssurance": false, then call deliver with app_rating_config_path:
"fastlane/age_rating.json" (keep other deliver options unchanged) so deliver
reads the age assurance from that JSON.
Summary by CodeRabbit