Skip to content

fix: add age assurance to fastfile#438

Merged
rhseung merged 1 commit into
gsainfoteam:developmentfrom
rhseung:rhseung/fastfile-patch
Feb 24, 2026
Merged

fix: add age assurance to fastfile#438
rhseung merged 1 commit into
gsainfoteam:developmentfrom
rhseung:rhseung/fastfile-patch

Conversation

@rhseung

@rhseung rhseung commented Feb 24, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • App Store 배포 설정 업데이트

@coderabbitai

coderabbitai Bot commented Feb 24, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

App Store 제출 구성을 확장하기 위해 iOS Fastlane Fastfile의 production lane 내 deliver(...) 호출에 age_assurance: 'none' 옵션을 추가했습니다. 기타 기능적 변경사항은 없습니다.

Changes

Cohort / File(s) Summary
Fastlane 구성
ios/fastlane/Fastfile
App Store 제출 옵션을 확장하기 위해 production lane의 deliver(...) 호출에 age_assurance: 'none' 매개변수 추가

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 한 줄 추가하니 설정이 완성되고,
App Store 제출이 더욱 부드러워지네!
age_assurance 옵션이 빛나는 순간,
배포의 새로운 장이 열렸다네~ ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목은 변경 사항의 주요 내용을 명확하게 설명합니다. Fastfile에 age_assurance 옵션을 추가하는 변경 사항을 정확히 나타냅니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rhseung rhseung requested a review from a team February 24, 2026 04:22
@rhseung rhseung enabled auto-merge (squash) February 24, 2026 04:22

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
ios/fastlane/Fastfile (1)

82-95: ⚠️ Potential issue | 🔴 Critical

deliver에서 age_assurance 옵션을 잘못 사용했습니다

Fastlane 2.229에서는 age_assurance: 'none'이 유효한 옵션이 아닙니다. 나이 보증 설정은 app_rating_config_path를 통해 JSON 파일로 전달되어야 하며, JSON 내에서 ageAssurance(카멜케이스)를 boolean 값(true/false)으로 설정해야 합니다. 현재 코드는 런타임 시 옵션 검증에서 실패합니다.

올바른 구현 방식
# fastlane/age_rating.json 파일 생성
{
  "ageAssurance": false
}

# deliver 호출
deliver(
  app_rating_config_path: "fastlane/age_rating.json",
  # ... 다른 옵션들
)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@ios/fastlane/Fastfile` around lines 82 - 95, The Fastfile is passing an
invalid deliver option age_assurance; remove the age_assurance: 'none' entry and
instead create a JSON file (e.g., fastlane/age_rating.json) containing the
camelCase boolean field "ageAssurance": false, then call deliver with
app_rating_config_path: "fastlane/age_rating.json" (keep other deliver options
unchanged) so deliver reads the age assurance from that JSON.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@ios/fastlane/Fastfile`:
- Around line 82-95: The Fastfile is passing an invalid deliver option
age_assurance; remove the age_assurance: 'none' entry and instead create a JSON
file (e.g., fastlane/age_rating.json) containing the camelCase boolean field
"ageAssurance": false, then call deliver with app_rating_config_path:
"fastlane/age_rating.json" (keep other deliver options unchanged) so deliver
reads the age assurance from that JSON.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8ec6e3b and b5f6b67.

📒 Files selected for processing (1)
  • ios/fastlane/Fastfile

@rhseung rhseung merged commit 9012e8d into gsainfoteam:development Feb 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants