Skip to content

fix: update promotional banner URL#436

Merged
rhseung merged 1 commit into
gsainfoteam:developmentfrom
rhseung:rhseung/pga-230
Feb 19, 2026
Merged

fix: update promotional banner URL#436
rhseung merged 1 commit into
gsainfoteam:developmentfrom
rhseung:rhseung/pga-230

Conversation

@rhseung

@rhseung rhseung commented Feb 19, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • 버그 수정
    • Infoteam 배너의 링크를 새로운 Notion 페이지로 업데이트했습니다.

@coderabbitai

coderabbitai Bot commented Feb 19, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

개요

Infoteam 배너의 onTap 핸들러에서 기존 Notion 링크를 새로운 Notion 페이지 링크로 변경했습니다. 로직이나 제어 흐름은 변경되지 않았습니다.

변경 사항

코호트 / 파일(s) 요약
배너 URL 업데이트
lib/app/modules/list/presentation/pages/list_page.dart
Infoteam 배너의 onTap 핸들러에서 Notion 링크 URL을 업데이트했습니다.

예상 코드 리뷰 노력

🎯 1 (Trivial) | ⏱️ ~2분

관련 가능성이 있는 PR

검토자 제안

  • 2paperstar

시 🐰

💫 오래된 링크를 새것으로 바꾸네,
노션 페이지가 반짝반짝 ✨
배너 클릭, 새로운 경로로!
작은 변화, 큰 기쁨 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목이 변경 사항의 주요 내용을 명확하게 설명합니다. 프로모션 배너 URL 업데이트라는 실제 변경 사항과 완벽하게 일치합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rhseung rhseung requested a review from a team February 19, 2026 03:23
@rhseung rhseung enabled auto-merge (squash) February 19, 2026 03:23

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
lib/app/modules/list/presentation/pages/list_page.dart (2)

30-38: launchUrlString 실패 시 사용자 피드백 없음

두 배너 모두 launchUrlString의 반환값(Future<bool>)을 무시하고 있습니다. URL을 열지 못한 경우(브라우저 미설치, 플랫폼 제한 등) 사용자에게 아무런 안내가 없습니다. 파일 내에 이미 context.showToast 확장이 있으므로, 콜백에 컨텍스트를 전달하거나 BannerEntry.onTapBuildContext를 받도록 수정하여 실패 시 토스트를 표시하는 것을 권장합니다.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@lib/app/modules/list/presentation/pages/list_page.dart` around lines 30 - 38,
The two BannerEntry onTap handlers call launchUrlString and ignore its
Future<bool> result; update the handlers to await the call (or use .then) and,
on a false result or caught error, call context.showToast to inform the user. If
BannerEntry.onTap currently takes no args, modify its signature to accept a
BuildContext (or pass the surrounding context into the closure) so you can call
context.showToast from the callback; ensure you handle exceptions from
launchUrlString and show an appropriate toast message when launch fails. Include
references to launchUrlString, BannerEntry, BannerEntry.onTap, and
context.showToast when making the change.

36-36: ?source=copy_link 추적 파라미터 제거 권장

Notion의 "링크 복사" 버튼을 사용할 때 자동으로 추가되는 트래킹 파라미터입니다. URL 탐색에는 영향을 주지 않으므로 소스 코드에서 제거하면 더 깔끔합니다.

🧹 제안 수정
-      'https://www.notion.so/infoteam-rulrudino/2026-309365ea27df80488137d0680fd51686?source=copy_link',
+      'https://www.notion.so/infoteam-rulrudino/2026-309365ea27df80488137d0680fd51686',
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@lib/app/modules/list/presentation/pages/list_page.dart` at line 36, Remove
the tracking query param from the Notion URL literal in list_page.dart by
replacing
'https://www.notion.so/infoteam-rulrudino/2026-309365ea27df80488137d0680fd51686?source=copy_link'
with the clean URL
'https://www.notion.so/infoteam-rulrudino/2026-309365ea27df80488137d0680fd51686'
wherever that string appears (e.g., in the list page link constant or widget
property) so the code contains the canonical Notion link without the unnecessary
?source=copy_link parameter.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@lib/app/modules/list/presentation/pages/list_page.dart`:
- Around line 30-38: The two BannerEntry onTap handlers call launchUrlString and
ignore its Future<bool> result; update the handlers to await the call (or use
.then) and, on a false result or caught error, call context.showToast to inform
the user. If BannerEntry.onTap currently takes no args, modify its signature to
accept a BuildContext (or pass the surrounding context into the closure) so you
can call context.showToast from the callback; ensure you handle exceptions from
launchUrlString and show an appropriate toast message when launch fails. Include
references to launchUrlString, BannerEntry, BannerEntry.onTap, and
context.showToast when making the change.
- Line 36: Remove the tracking query param from the Notion URL literal in
list_page.dart by replacing
'https://www.notion.so/infoteam-rulrudino/2026-309365ea27df80488137d0680fd51686?source=copy_link'
with the clean URL
'https://www.notion.so/infoteam-rulrudino/2026-309365ea27df80488137d0680fd51686'
wherever that string appears (e.g., in the list page link constant or widget
property) so the code contains the canonical Notion link without the unnecessary
?source=copy_link parameter.

@rhseung rhseung merged commit 8ec6e3b into gsainfoteam:development Feb 19, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants