-
Notifications
You must be signed in to change notification settings - Fork 5
refactor: use Iconoir library instead of svg files #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| import Close from '@/assets/icons/close.svg'; | ||
| import { Xmark } from 'iconoir-react'; | ||
|
|
||
| interface MemberCardProps { | ||
| name: string; | ||
|
|
@@ -29,7 +29,7 @@ const MemberCard = ({ | |
| </div> | ||
| </div> | ||
|
|
||
| <Close onClick={onCloseClick} className="w-6" /> | ||
| <Xmark color="rgb(110, 110, 115)" onClick={onCloseClick} className="w-6" /> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 마찬가지로 하드 코딩된 색 대신 토큰을 |
||
| </li> | ||
| ); | ||
| }; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ import useSWR from "swr"; | |
| import { getGroupMembers } from "@/apis/group"; | ||
| import { useOutletContext, useParams } from "react-router-dom"; | ||
|
|
||
| import UserCircle from "@/assets/icons/user-circle.svg?react"; | ||
| import { UserCircle } from 'iconoir-react'; | ||
|
|
||
| import { useTranslation } from "react-i18next"; | ||
| import { GroupDetailContext } from "../../DetailPageLayout"; | ||
|
|
@@ -31,7 +31,7 @@ const GroupMembersTab = () => { | |
| return ( | ||
| <div className="flex flex-col items-center"> | ||
| <div className="flex gap-1.5 mt-6"> | ||
| <UserCircle /> | ||
| <UserCircle color="rgb(110, 110, 115)" /> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 마찬가지로 하드 코딩된 색 대신 토큰을 |
||
| <div className={"text-[18px] text-greyDark"}> | ||
| {t("group.memberCount", { count: group.memberCount })} | ||
| </div> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,6 @@ | ||
| import { GroupInfoWithPresidentUuid } from "src/types/interfaces"; | ||
|
|
||
| import ArrowRight from "@/assets/icons/arrow-right.svg?react"; | ||
| import Crown from "@/assets/icons/crown.svg?react"; | ||
| import Settings from "@/assets/icons/settings.svg?react"; | ||
| import { NavArrowRight, Settings, Crown } from 'iconoir-react'; | ||
| import GroupProfileDefault from "@/assets/icons/group-profile-default.webp"; | ||
| import Card from "@/components/card/Card"; | ||
| import { Link } from "react-router-dom"; | ||
|
|
@@ -42,18 +40,18 @@ const GroupItem = ({ | |
| </p> | ||
|
|
||
| {isAdmin && ( | ||
| <Crown className="ml-1 inline stroke-dark dark:stroke-d_white" /> | ||
| <Crown color="rgb(235, 85, 40)" className="ml-1 inline stroke-dark dark:stroke-d_white" /> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 마찬가지로 하드 코딩된 색 대신 토큰을 |
||
| )} | ||
|
|
||
| <div className="flex-grow" /> | ||
|
|
||
| {isAdmin && ( | ||
| <Link to={`/manage/${group.uuid}/groupinfo`}> | ||
| <Settings className="fill-greyDark mr-2" /> | ||
| <Settings color="rgb(110, 110, 115)" className="fill-greyDark mr-2" /> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 마찬가지로 하드 코딩된 색 대신 토큰을 |
||
| </Link> | ||
| )} | ||
|
|
||
| <ArrowRight className="h-[30px] stroke-dark dark:stroke-d_white" /> | ||
| <NavArrowRight className="h-[30px] stroke-dark dark:stroke-d_white" /> | ||
| </a> | ||
| </Card> | ||
| ); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -63,7 +63,7 @@ const MemberTableRow = ({ | |
| {/* 이름 */} | ||
| <th className={cn(cellStyle, "text-greyDark")}> | ||
| <div className="flex items-center gap-2"> | ||
| {member.name} {isThisMemberPresident && <Crown />} | ||
| {member.name} {isThisMemberPresident && <Crown color="rgb(235, 85, 40)" />} | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 마찬가지로 하드 코딩된 색 대신 토큰을 |
||
| </div> | ||
| </th> | ||
| {/* 이메일 */} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
color를 하드 코딩하지 말고, css에 있는 토큰을 사용해주세요. 아마 className에서
text-primary를 사용하면 될 거예요