fix: Reintroduce symlink work behind experiment flag #3672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levkohimins
requested changes
Dec 17, 2024
denis256
reviewed
Dec 17, 2024
denis256
reviewed
Dec 17, 2024
| @@ -146,7 +179,7 @@ func (src Source) WriteVersionFile() error { | |||
| // 1. Always download source URLs pointing to local file paths. | |||
| // 2. Only download source URLs pointing to remote paths if /T/W/H doesn't already exist or, if it does exist, if the | |||
| // version number in /T/W/H/.terragrunt-source-version doesn't match the current version. | |||
| func NewSource(source string, downloadDir string, workingDir string, logger log.Logger) (*Source, error) { | |||
| func NewSource(source string, downloadDir string, workingDir string, logger log.Logger, walkWithSymlinks bool) (*Source, error) { | |||
There was a problem hiding this comment.
Nit: Can we add a structure to pass data in? more args will make complicated to understand values
There was a problem hiding this comment.
If you don't mind, I'd like to punt on that. I think we should eventually just switch to options from a variadic argument.
denis256
approved these changes
Dec 17, 2024
levkohimins
approved these changes
Dec 18, 2024
yhakbar
deleted the
fix/reintroduce-symlink-work-behind-experiment-flag
branch
|
Thanks so much for addressing this so quickly and thoughtfully. I really appreciate the effort to put this behind a feature flag—it’s a great solution that balances flexibility and safety, even though it’s more work on your end. Your responsiveness and attention to detail are what make contributing to this project such a great experience. 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3654.
We have other experiments like the following that need to be pulled into this system if we don't have any problems with the design:
To ensure backwards compatibility, when they get pulled in, the existing flags that they use will be added to a strict control that warns users they are using a legacy experiment control mechanism, and should switch to using this new system.
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added new
experimentsystem. This system allows you to enable experimental features of Terragrunt before they're stable.Removed Symlink support by default. Users have to opt-in to use it via the new
experimentsystem.Migration Guide
Users using the current ability to find symlinked units in their stacks will now need to explicitly enable the
symlinksexperiment to continue using this feature.e.g.
For information on how to use the new
experimentsystem, see the Experiments documentation (which will go live once this PR is merged).