Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added exclude_from_copy to config #3543

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

KabaevRoman
Copy link

@KabaevRoman KabaevRoman commented Nov 10, 2024

Description

Fixes #916.

Added exclude_from_copy to config, to exclude some paths via globs

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@KabaevRoman
Copy link
Author

Don't know if exclude_in_copy syntactically correct, if I should rename exclude_from_copy to exclude_in_copy, or made mistakes in formatting/code let me know!

@KabaevRoman
Copy link
Author

KabaevRoman commented Nov 10, 2024

config tests > https://gist.github.com/KabaevRoman/17cbee1e7cacb6e154d0ae18945c898f
util tests > https://gist.github.com/KabaevRoman/f7f4bc1aa456d9f0326547db8fa4b4bf
Not really sure how to run integration tests, I don't have an aws account available, if it's possible would be nice to kick of pipeline in github

Copy link
Collaborator

@yhakbar yhakbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @KabaevRoman,

Sorry we haven't gotten around to reviewing this until now. I'll look to kick off CI later today.

In the meantime, do you mind adding documentation and testing specifically around the scenario where files are listed as both included and excluded? I would assume that the safest thing to do would be to exclude them in that circumstance.

You should be able to run most of the tests in this repository without an AWS account, etc. We've done some work fairly recently to move all tests that require external integrations to require build tags, so they shouldn't run by default.

You might want to be targeted with your tests by doing something like this anyways, though:

go test -run 'NameOfTest'

We have a goal of making it so that contributors can easily run tests locally, so any help you could provide to make that a better experience would be much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude copying folder from working directory to cache folder
2 participants