Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A88: xDS Data Error Handling #466

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
+552 −0
Open

A88: xDS Data Error Handling #466

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
c6b1106
WIP
markdroth Nov 21, 2024
040623f
more details
markdroth Nov 22, 2024
5f80d81
update method names
markdroth Nov 22, 2024
4903bf6
fix table entries for resource timer
markdroth Dec 7, 2024
e68b3ed
shorten server feature name
markdroth Dec 7, 2024
57adb03
new watcher approach
markdroth Dec 9, 2024
1417a0d
improve table formatting
markdroth Dec 9, 2024
1a7df04
env var also guards ignore_resource_deletion behavior
markdroth Dec 12, 2024
da97419
add section on XdsClient metrics
markdroth Dec 13, 2024
bc9b9c2
timer status changes with server feature
markdroth Dec 14, 2024
ae4458c
add mailing list link
markdroth Dec 16, 2024
d47e5fd
clarify handling of xRFC TP3 errors
markdroth Dec 16, 2024
ba7950e
add note about status code propagation to data plane RPCs
markdroth Dec 16, 2024
6b2decc
review comments
markdroth Dec 17, 2024
bbe760a
describe how to clear an ambient error
markdroth Dec 23, 2024
f8c28d9
clarify how the resource timer affects the cache now
markdroth Jan 2, 2025
1c463a5
add links to C-core impl
markdroth Jan 2, 2025
5e68ac3
add ambient error handling
markdroth Jan 3, 2025
85662e2
describe cache state more clearly
markdroth Jan 4, 2025
b98a315
add another C-core PR
markdroth Jan 8, 2025
0c8c209
review changes
markdroth Jan 16, 2025
d5d5960
more review changes
markdroth Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
add links to C-core impl
@markdroth
markdroth committed Jan 2, 2025
commit 1c463a541344256402b4c716a8a00a10e8e0d19d
6 changes: 5 additions & 1 deletion A88-xds-data-error-handling.md
View file
Original file line number Diff line number Diff line change
@@ -381,7 +381,11 @@ behavior outside of the XdsClient.

## Implementation

@markdroth will implement in C-core.
C-core implementation:
- XdsClient watcher API change: https://github.com/grpc/grpc/pull/38269
- Support for "fail_on_data_errors": https://github.com/grpc/grpc/pull/38278
- Support for "resource_timer_is_transient_failure": https://github.com/grpc/grpc/pull/38377
- xRFC TP3 support: TBD

Will also be implemented in Java, Go, and Node.