Add a new field, transportSpecific to ServerContext #2228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Currently there's no way to plumb through details from the transport level to a request handler. Adding this field allows transports, such as the nio transport, to add the peer certificate to the server context when using mTLS. From there there it's easy for an interceptor to take this data and propogate it forward to a request handler. Modifications: This PR adds a single field to the ServerContext that transports can use Result: A new field will be accessible to transports and consumers of the API
glbrntt
requested changes
May 1, 2025
| /// | ||
| /// An example of what this field can be used for, would be to store | ||
| /// things like a peerCertificate from a mTLS connection | ||
| public var transportSpecific: (any Sendable)? |
There was a problem hiding this comment.
I thought about this some more, rather than any Sendable can you define a public protocol TransportSpecific: Sendable {} nested within ServerContext and use that instead?
It has a few advantages:
- Compiler helps users out a little more
- It's easier to document and easier for users to find implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Currently there's no way to plumb through details from the transport level to a request handler. Adding this field allows transports, such as the nio transport, to add the peer certificate to the server context when using mTLS.
From there there it's easy for an interceptor to take this data and propogate it forward to a request handler.
Modifications:
This PR adds a single field to the ServerContext that transports can use
Result:
A new field will be accessible to transports and consumers of the API