Set tolerance to zero when using Task.sleep#2225
Merged
Conversation
glbrntt
approved these changes
Apr 25, 2025
Collaborator
glbrntt
left a comment
glbrntt
left a comment
There was a problem hiding this comment.
LGTM but the formatter is unhappy
dongjoon-hyun
added a commit
to apache/spark-connect-swift
that referenced
this pull request
May 12, 2025
### What changes were proposed in this pull request? This PR aims to upgrade `gRPC Swift` to 2.2.0 to use `Swift 6.1`-tested versions from the upstream officially. ### Why are the changes needed? To bring the latest updates. - https://github.com/grpc/grpc-swift/releases/tag/2.2.0 (2025-05-12) - grpc/grpc-swift#2225 - grpc/grpc-swift#2221 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #135 from dongjoon-hyun/SPARK-52084. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task.sleepwill by default try and coalesce multiple timers into one, mostly for client-specific reasons such as performance, power consumption, etc.However, this is undesirable on servers, as it can increase latency, memory usage, and (in the case of gRPC) may result in timeouts not firing when they should.
We can avoid this by setting the sleep
toleranceto zero.