Skip to content

Expose APIs to customise NWParameters when using NIOTS #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 25, 2025

Conversation

gjcairo
Copy link
Collaborator

@gjcairo gjcairo commented Apr 24, 2025

swift-nio-transport-services added support for customising the NWParameters used in the underlying connections in apple/swift-nio-transport-services#230.

This PR adds API in grpc-swift v1 to allow users to customise the bootstraps used when creating gRPC connections using NIOTS. This will allow them to, for example, customise their NWParameters using the new APIs in swift-nio-transport-services.

@gjcairo gjcairo requested a review from glbrntt April 24, 2025 14:13
@glbrntt glbrntt added the 🆕 semver/minor Adds new public API. label Apr 25, 2025
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small questions otherwise this looks good

@gjcairo gjcairo force-pushed the niots-nwparams-configurator branch from 710ddef to 2ea83c2 Compare April 25, 2025 12:18
@gjcairo gjcairo requested a review from glbrntt April 25, 2025 14:08
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gus!

@glbrntt glbrntt merged commit 3bbd57b into grpc:release/1.x Apr 25, 2025
12 of 14 checks passed
@gjcairo gjcairo changed the title Expose APIs to customise NIOTS bootstraps Expose APIs to customise NWParameters when using NIOTS Apr 25, 2025
@gjcairo gjcairo deleted the niots-nwparams-configurator branch April 25, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants