grpc/child_manager: use generic child builder - #2851
Merged
Conversation
dfawley
reviewed
Sep 8, 2026
dfawley
left a comment
Member
There was a problem hiding this comment.
After chatting with @LucioFranco, it's probably best to remove the auto_impl usage for now. It seems like people take the proc macro costs pretty seriously, and we also might be able to tweak the way we use serde to avoid it, too... But if we start adopting this crate, then we'll have more work to do if we do want to do that.
dfawley
approved these changes
Sep 8, 2026
dfawley
left a comment
Member
There was a problem hiding this comment.
Everything else LGTM, so approving for when that's removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to: #2761
Make
ChildManagergeneric over theLbPolicyBuildertype it manages.Previously, type checking for LB policies and their configuration types relied on runtime invariants enforced by
DynAdapter. ParameterizingChildManagerprovides compile-time guarantees for these types.As a result:
RoundRobinnow manages concrete, non-type-erasedPickFirstchildren.Prioritywill manageGracefulSwitchchildren.Additional Changes
RoundRobintests to use the realPickFirstbalancer rather than test stubs.