Update health.proto to add objc prefix #166
Open
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sampajano
reviewed
Jan 18, 2025
There was a problem hiding this comment.
@markdroth thanks for cc'ing!
LGTM. But @HannahShiSFB Could you also help take a look please? Thanks!
sampajano
approved these changes
Jan 18, 2025
There was a problem hiding this comment.
Thanks for the change! I'll approve first :)
@HannahShiSFB if there's any concerns please let me know afterwards :)
|
I'm not familiar with it, would you clarify why the change and what will be affected? |
|
Thanks! The prefix is needed so that I can call the health check from ios grpc clients.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.