Skip to content

Health list endpoint #2957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MatiasManevi
Copy link
Contributor

@MatiasManevi MatiasManevi commented May 17, 2025

Change

This PR introduces the implementation of the new List endpoint to the Health service in order to list all the services that a certain server is watching to.

It also adds generated files for the endpoint and its tests.

I would like to write some tests too but I couldn't run the test suite as it is as I get some errors, any help is appreciated.

gulpfile.ts:28:19 - error TS2339: Property 'parallel' does not exist on type 'Gulp'.
28 const lint = gulp.parallel(jsCore.lint);
gulpfile.ts:30:20 - error TS2339: Property 'series' does not exist on type 'Gulp'.
30 const build = gulp.series(protobuf.compile, jsCore.compile, jsXds.compile);

Related PR

gRPC-proto added in #2951

Proposal

grpc/proposal#468

@murgatroid99
Copy link
Member

If you run npm install and gulp setup in the repository root directory, that should set everything up to be able to run those tests.

@MatiasManevi
Copy link
Contributor Author

MatiasManevi commented May 20, 2025

If you run npm install and gulp setup in the repository root directory, that should set everything up to be able to run those tests.

Thank you for the guidance!

Running gulp setup is being problematic. Some deps not working

[20:00:23] Finished '<anonymous>' after 11 s
[20:00:23] Starting 'install'...
npm error Cannot read properties of null (reading 'isDescendantOf')
npm error A complete log of this run can be found in: /home/matias/.npm/_logs/2025-05-20T23_00_23_644Z-debug-0.log
[20:03:50] 'install' errored after 3.45 min
[20:03:50] Error: exited with error code: 1
    at ChildProcess.onexit (/home/matias/projects/grpc-node/node_modules/end-of-stream/index.js:40:36)
    at ChildProcess.emit (node:events:536:35)
    at ChildProcess.emit (node:domain:552:15)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:293:12)
    at Process.callbackTrampoline (node:internal/async_hooks:130:17)
[20:03:50] 'setup' errored after 3.79 min

My node version is 22.13.1, I use nvm.

Does this PR depend on unit tests to be "approvable"? I can add the test code and someone else can try to run them?

@murgatroid99
Copy link
Member

I think the most likely issue you are seeing is that the git submodules that the setup script expects to be able to use are absent. You can correct that by running git submodule update --init --recursive. Alternatively, you can run a smaller set of install scripts directly, by running npm install in the root directory, in packages/proto-loader, in packages/grpc-js, and in packages/health-check, in that order.

@MatiasManevi
Copy link
Contributor Author

MatiasManevi commented May 22, 2025

I think the most likely issue you are seeing is that the git submodules that the setup script expects to be able to use are absent. You can correct that by running git submodule update --init --recursive. Alternatively, you can run a smaller set of install scripts directly, by running npm install in the root directory, in packages/proto-loader, in packages/grpc-js, and in packages/health-check, in that order.

Thank you!, second approach worked (even tho 29 tests fail). I will work on the tests shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants