rls: Control plane channel monitor state and back off handling #12460
+248
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix test. Unit test. Save changes. In-progress changes for control plane connectivity state monitoring. Test for making backoff timer expiry not make a RLS rpc directly but update the parent LB policy with picker after deleting backoff cache entry. Save in-progress changes. Save changes.
…hannel-monitor-state
Remove unused class.
ejona86
reviewed
Oct 31, 2025
…e because of the mixup in the Lru cache code logic, with expiry time.
…-monitor-state # Conflicts: # rls/src/main/java/io/grpc/rls/CachingRlsLbClient.java
# Conflicts: # rls/src/main/java/io/grpc/rls/CachingRlsLbClient.java # rls/src/test/java/io/grpc/rls/CachingRlsLbClientTest.java
ejona86
approved these changes
Nov 4, 2025
| synchronized (lock) { | ||
| for (CacheEntry value : linkedHashLruCache.values()) { | ||
| if (value instanceof BackoffCacheEntry) { | ||
| refreshBackoffEntry((BackoffCacheEntry) value); |
There was a problem hiding this comment.
FYI: This could end up calling helper.triggerPendingRpcProcessing() quite a few times. (FWIW, the scheduledFuture.cancel() in the method probably doesn't matter much for the scheduled task, but is important here.)
…l plane transitions to READY.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the end of back off time, instead of firing a Rls RPC, just update the RLS picker, and RLS connectivity state change from TRANSIENT_FAILURE to READY deactivate all active backoffs.