api: When forwarding from Listener onAddresses to Listener2 continue to use onResult #11666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ization context to call it from inside of the synchronization context. Fixes grpc#11662.
ejona86
reviewed
Nov 5, 2024
| Collections.singletonList(new EquivalentAddressGroup(address)))) | ||
| .setAttributes(Attributes.EMPTY) | ||
| .build()); | ||
| args.getSynchronizationContext().execute(() -> |
There was a problem hiding this comment.
I don't see why this was added. start() should be called from the synchronization context.
| @@ -58,7 +60,8 @@ private void resolve() { | |||
| List<EquivalentAddressGroup> servers = new ArrayList<>(1); | |||
| servers.add(new EquivalentAddressGroup(new DomainSocketAddress(authority))); | |||
| resolutionResultBuilder.setAddressesOrError(StatusOr.fromValue(servers)); | |||
| listener.onResult2(resolutionResultBuilder.build()); | |||
| args.getSynchronizationContext().execute(() -> | |||
There was a problem hiding this comment.
This was also fine, because start() and refresh() are called from the synchronization context.
…d from sync context.
kannanjgithub
changed the title
ejona86
approved these changes
Nov 5, 2024
kannanjgithub
changed the title
|
Fixes #11662 |
ejona86
added
the
TODO:backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When forwarding from Listener onAddresses to Listener2 continue to use onResult and not onResult2 because the latter requires to be called from within synchronization context and it breaks existing code that didn't need to do so when using the old Listener interface.