Added support for writing Etag headers and handling If-None-Match request headers #4262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joshgarnett
commented
Apr 26, 2024
•
joshgarnett
commented
- Entity tags (Etag) are used to identify specific versions of a resource. CDNs and Clients will use this in future requests to the server, using the If-None-Match header, to specify what data they already have and reduce the amount of data transferred if they already have the latest version.
- The Etag is only written for GET requests with messages greater than 100 bytes and is set to the md5 hash of the message.
- If a client sends the If-None-Match request header, the server will compare that value to the calculated etag. If they match, it will return http.StatusNotModified (304) and not write the message in the response.
- Added additional tests to ensure the correct headers are being returned and that If-None-Match works.
…uest headers * Entity tags (Etag) are used to identify specific versions of a resource. CDNs and Clients will use this in future requests to the server, using the If-None-Match header, to specify what data they already have and reduce the amount of data transferred if they already have the latest version. * The Etag is only written for messages greater than 100 bytes. It is set to the md5 hash of the message. * If a client sends the If-None-Match request header, the server will compare that value to the calculated etag. If they match, it will return http.StatusNotModified (304) and not write the message in the response. * Added additional tests to ensure the correct headers are being returned and that If-None-Match works.
…for GET requests as per the standard
|
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/ETag has more details on how this should be implemented |
|
I appreciate the work put into this, but please open an issue first to discuss how to move forward with a feature request before opening a PR, to save us both time. |
… on the TailerMD, which is a map. The order a map is returned is non-deterministic.
|
Good call out @johanbrandhorst, I almost created one first, but ended up being able to throw the code together fairly quickly. Do you want me to still open one? |
|
Yes please |
|
Fixes #4263 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.